-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PortfolioView swap native token bug #28639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [77c0ad0]
Page Load Metrics (1855 ± 68 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gambinish
added
DO-NOT-MERGE
Pull requests that should not be merged
and removed
DO-NOT-MERGE
Pull requests that should not be merged
labels
Nov 22, 2024
Builds ready [5da7495]
Page Load Metrics (2058 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…sBridgeChain selectors
Prithpal-Sooriya
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as a second reviewer. Can someone with more domain knowledge double check it?
Builds ready [591cc4b]
Page Load Metrics (1625 ± 51 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gambinish
added
the
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
label
Nov 25, 2024
darkwing
approved these changes
Nov 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 25, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
PORTFOLIO_VIEW
feature flag is enabled, when swapping a native token from a different chain than the globally selected chain, the incorrect native token would be prepoulated in thefromToken
in the swap UI.For instance, if user is on Ethereum mainnet, navigated to POL, then attempted to swap, the globally selected network would change from Ethereum mainnet to Polygon mainnet (expected), but the swaps
fromToken
would still be POL (unexpected)Changes in this PR fixes this, and prepoulates
fromToken
with the native token from the correct chain.Related issues
Fixes: #28534
Manual testing steps
PORTFOLIO_VIEW=1 yarn webpack --watch
Screenshots/Recordings
Screen.Recording.2024-11-21.at.2.41.16.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist