-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cross chain swaps - tx status - BridgeStatusController #28636
Merged
HowardBraham
merged 4 commits into
develop
from
cross-chain-swaps-bridgeStatusController
Nov 26, 2024
Merged
feat: cross chain swaps - tx status - BridgeStatusController #28636
HowardBraham
merged 4 commits into
develop
from
cross-chain-swaps-bridgeStatusController
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [b1ba642]
Page Load Metrics (1906 ± 119 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
infiniteflower
changed the title
chore: commit all background code
feat: cross chain swaps - tx status - BridgeStatusController
Nov 22, 2024
micaelae
reviewed
Nov 22, 2024
app/scripts/controllers/bridge-status/bridge-status-controller.ts
Outdated
Show resolved
Hide resolved
7 tasks
Builds ready [8fc0d07]
Page Load Metrics (2175 ± 95 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
approved these changes
Nov 22, 2024
ghgoodreau
approved these changes
Nov 22, 2024
jclancy93
approved these changes
Nov 26, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a collection of all the background related code from #27740 (no UI changes). It has been split up in order to make it easier to review. A follow up PR containing all the UI changes from #27740 is here: #28657
The main addition is the
BridgeStatusController
and its supporting code.If you would like to test the functionality of this PR through the UI, please do so through #27740.
Related issues
Branched off from #27740
Manual testing steps
Refer to #27740
Screenshots/Recordings
Refer to #27740
Pre-merge author checklist
Pre-merge reviewer checklist