Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cross chain swaps - tx status - BridgeStatusController #28636

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Nov 21, 2024

Description

This PR is a collection of all the background related code from #27740 (no UI changes). It has been split up in order to make it easier to review. A follow up PR containing all the UI changes from #27740 is here: #28657

The main addition is the BridgeStatusController and its supporting code.

If you would like to test the functionality of this PR through the UI, please do so through #27740.

Open in GitHub Codespaces

Related issues

Branched off from #27740

Manual testing steps

Refer to #27740

Screenshots/Recordings

Refer to #27740

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b1ba642]
Page Load Metrics (1906 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27025361670610293
domContentLoaded159924611876225108
load160725451906249119
domInteractive149135199
backgroundConnect8136273316
firstReactRender501541052512
getState46517199
initialActions01000
loadScripts11161821136418489
setupStore56417189
uiStartup179128222118263126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.36 KiB (0.21%)
  • ui: 0 Bytes (0.00%)
  • common: 76 Bytes (0.00%)

@infiniteflower infiniteflower changed the title chore: commit all background code feat: cross chain swaps - tx status - BridgeStatusController Nov 22, 2024
@infiniteflower infiniteflower marked this pull request as ready for review November 22, 2024 15:43
@infiniteflower infiniteflower requested a review from a team as a code owner November 22, 2024 15:43
@metamaskbot
Copy link
Collaborator

Builds ready [8fc0d07]
Page Load Metrics (2175 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25825531870699336
domContentLoaded18632486212718890
load18962546217519795
domInteractive278444189
backgroundConnect997472813
firstReactRender773801447134
getState66523199
initialActions01000
loadScripts13301880156115775
setupStore711911
uiStartup212132202459272131
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.32 KiB (0.21%)
  • ui: 0 Bytes (0.00%)
  • common: 161 Bytes (0.00%)

@HowardBraham HowardBraham added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 8773328 Nov 26, 2024
78 checks passed
@HowardBraham HowardBraham deleted the cross-chain-swaps-bridgeStatusController branch November 26, 2024 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-swaps
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants