test: Add integration test for signing and submitting alert and fix b… #28616

pnarayanaswamy · 2024-11-21T14:49:05Z

…ug of confirm button not being disabled

Description

Adds integration test to check alert for signing and submitting
Fixes bug 'Confirm button not disabled when alert is displayed'

Related issues

Fixes: #2975

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ug of confirm button not being disabled

github-actions · 2024-11-21T14:49:17Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-21T15:45:00Z

Builds ready [5cdcd88]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1873 ± 162 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1558	2767	1910	352	169
		domContentLoaded	1549	2635	1841	332	160
		load	1557	2665	1873	338	162
		domInteractive	25	91	45	20	10
		backgroundConnect	9	124	31	30	14
		firstReactRender	66	392	150	89	43
		getState	4	80	25	26	13
		initialActions	0	1	0	0	0
		loadScripts	1138	1997	1368	264	127
		setupStore	5	51	12	13	6
		uiStartup	1729	3322	2182	467	224

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 131 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-22T09:15:52Z

Builds ready [382f67b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2255 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	288	2579	2155	460	221
		domContentLoaded	1924	2495	2209	165	79
		load	1955	2572	2255	167	80
		domInteractive	18	106	60	28	13
		backgroundConnect	7	155	46	34	16
		firstReactRender	95	177	129	19	9
		getState	7	107	33	26	13
		initialActions	0	37	2	8	4
		loadScripts	1447	1893	1650	136	65
		setupStore	6	15	10	2	1
		uiStartup	2235	2892	2518	191	92

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 131 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-26T09:02:51Z

Builds ready [067fe42]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2138 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	387	2405	1901	598	287
		domContentLoaded	1854	2343	2089	140	67
		load	1887	2404	2138	144	69
		domInteractive	23	269	71	63	30
		backgroundConnect	9	92	49	26	12
		firstReactRender	73	171	110	24	12
		getState	8	63	27	19	9
		initialActions	0	1	0	0	0
		loadScripts	1360	1768	1539	124	60
		setupStore	7	56	13	13	6
		uiStartup	2062	2660	2354	164	79

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 99 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-26T13:00:56Z

Builds ready [50f02dc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2072 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	297	2432	1639	723	347
		domContentLoaded	1674	2369	2040	191	92
		load	1691	2435	2072	184	88
		domInteractive	26	196	68	45	22
		backgroundConnect	6	189	34	42	20
		firstReactRender	60	403	159	78	37
		getState	3	66	22	21	10
		initialActions	0	1	0	0	0
		loadScripts	1244	1795	1521	162	78
		setupStore	6	81	18	23	11
		uiStartup	1895	2790	2398	218	105

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-28T08:01:11Z

Builds ready [21fc776]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2308 ± 168 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	305	2819	1865	821	394
		domContentLoaded	1683	2769	2274	348	167
		load	1693	2805	2308	351	168
		domInteractive	26	183	65	37	18
		backgroundConnect	9	77	33	23	11
		firstReactRender	15	171	42	42	20
		getState	51	206	102	36	17
		initialActions	0	1	0	0	0
		loadScripts	1283	2194	1778	285	137
		setupStore	6	54	15	12	6
		uiStartup	1900	3432	2677	478	229

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-28T11:05:41Z

Builds ready [d28e6cb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2142 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	280	2372	1758	726	348
		domContentLoaded	1775	2421	2119	181	87
		load	1788	2429	2142	182	87
		domInteractive	27	114	46	21	10
		backgroundConnect	8	70	27	19	9
		firstReactRender	16	47	26	8	4
		getState	57	136	104	18	9
		initialActions	0	1	0	0	0
		loadScripts	1372	1873	1637	144	69
		setupStore	7	12	9	1	1
		uiStartup	1988	2807	2439	224	107

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona

LGTM!

test: Add integration test for signing and submitting alert and fix b…

3168b73

…ug of confirm button not being disabled

pnarayanaswamy requested review from a team as code owners November 21, 2024 14:49

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 21, 2024

chore: refactor to disable confirm button

5cdcd88

test: remove preview debug

382f67b

pnarayanaswamy added 2 commits November 26, 2024 15:31

chore: make confirm button danger and blocking

337bce7

chore: remove jest preview

067fe42

pnarayanaswamy added 2 commits November 26, 2024 19:26

chore: revert changes to disable button

e58b16d

chore: revert changes to field name

50f02dc

Merge branch 'develop' into signing-alert-it

21fc776

Merge branch 'develop' into signing-alert-it

d28e6cb

pedronfigueiredo approved these changes Nov 28, 2024

View reviewed changes

OGPoyraz approved these changes Dec 3, 2024

View reviewed changes

pnarayanaswamy enabled auto-merge December 3, 2024 11:34

seaona approved these changes Dec 5, 2024

View reviewed changes

pnarayanaswamy added this pull request to the merge queue Dec 5, 2024

Merged via the queue into main with commit fc5c01f Dec 5, 2024
75 checks passed

pnarayanaswamy deleted the signing-alert-it branch December 5, 2024 10:01

github-actions bot locked and limited conversation to collaborators Dec 5, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add integration test for signing and submitting alert and fix b… #28616

test: Add integration test for signing and submitting alert and fix b… #28616

pnarayanaswamy commented Nov 21, 2024 •

edited

Loading

github-actions bot commented Nov 21, 2024

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 22, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

seaona left a comment

test: Add integration test for signing and submitting alert and fix b… #28616

test: Add integration test for signing and submitting alert and fix b… #28616

Conversation

pnarayanaswamy commented Nov 21, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 21, 2024

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 22, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

seaona left a comment

Choose a reason for hiding this comment

pnarayanaswamy commented Nov 21, 2024 •

edited

Loading