Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Prevent Sentry from auto-generating spans for requests to Sentry #28613

Merged
merged 3 commits into from
Nov 27, 2024
+6 −1
Merged

perf: Prevent Sentry from auto-generating spans for requests to Sentry #28613

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9142f93
Set up `shouldCreateSpanForRequest` option for sentry `browserTracing…
MajorLift Nov 21, 2024
cfdcfcc
Fix regex for Sentry urls and add checks to ensure that correct doma…
MajorLift Nov 22, 2024
0552f10
Linter fix
MajorLift Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/scripts/lib/setupSentry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,14 @@ function getClientOptions() {
integrations: [
Sentry.dedupeIntegration(),
Sentry.extraErrorDataIntegration(),
Sentry.browserTracingIntegration(),
Sentry.browserTracingIntegration({
shouldCreateSpanForRequest: (url) => {
// Do not create spans for outgoing requests to a 'sentry.io' domain.
return !url.match(
/^https?:\/\/([\w\d.@-]+\.)?sentry\.io(\/|$)/u
);
MajorLift marked this conversation as resolved.
Show resolved Hide resolved
},
}),
filterEvents({ getMetaMetricsEnabled, log }),
],
release: RELEASE,
Expand Down
Loading