Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix test networks display for portfolio view #28601

Merged

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Nov 21, 2024

Description

This PR fixes the display in the asset page and in the main token list when the price checker setting is off

Open in GitHub Codespaces

Related issues

Fixes: #28594

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2024-11-21.at.18.16.39.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri force-pushed the fix/portfolio-view-testnetwork-conversion-setting branch 2 times, most recently from f8245d4 to 5430f87 Compare November 21, 2024 11:42
@metamaskbot
Copy link
Collaborator

Builds ready [5430f87]
Page Load Metrics (2107 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27825512019433208
domContentLoaded17762486206216077
load18022555210716780
domInteractive23105482110
backgroundConnect8122523617
firstReactRender582941174823
getState691242210
initialActions01000
loadScripts12931958151815374
setupStore66220199
uiStartup200027992366215103
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 8.14 KiB (0.11%)
  • common: 1.85 KiB (0.02%)

@sahar-fehri sahar-fehri marked this pull request as ready for review November 21, 2024 17:07
@sahar-fehri sahar-fehri requested a review from a team as a code owner November 21, 2024 17:07
gambinish
gambinish previously approved these changes Nov 21, 2024
Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the recording. LGTM.

Let's also get Salim to look this over since we are trying to sequence our PRs. Let's wait for his approval before merging it 👍

salimtb
salimtb previously approved these changes Nov 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c8e2452]
Page Load Metrics (1797 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19522651720390187
domContentLoaded14782181175315675
load15492282179717383
domInteractive14109372211
backgroundConnect8148493818
firstReactRender6355414411053
getState4143283517
initialActions01000
loadScripts10551668128813565
setupStore575172311
uiStartup183427172094255123
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 9.14 KiB (0.12%)
  • common: 1.85 KiB (0.02%)

Base automatically changed from feat/portfolio-view to develop November 21, 2024 18:14
@gambinish gambinish dismissed stale reviews from salimtb and themself November 21, 2024 18:14

The base branch was changed.

@mcmire mcmire requested a review from a team as a code owner November 21, 2024 18:14
@sahar-fehri sahar-fehri force-pushed the fix/portfolio-view-testnetwork-conversion-setting branch from e130366 to a2c3a7d Compare November 21, 2024 18:28
@metamaskbot
Copy link
Collaborator

Builds ready [a2c3a7d]
Page Load Metrics (1994 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17802337199914771
domContentLoaded17582313196314771
load17622381199415575
domInteractive23493273
backgroundConnect117031199
firstReactRender971731272110
getState65618189
initialActions00000
loadScripts12481795145212359
setupStore664212211
uiStartup20022571223415675
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 940 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@sahar-fehri sahar-fehri added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit 08cc205 Nov 21, 2024
75 checks passed
@sahar-fehri sahar-fehri deleted the fix/portfolio-view-testnetwork-conversion-setting branch November 21, 2024 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
5 participants