-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix test networks display for portfolio view #28601
fix: fix test networks display for portfolio view #28601
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
f8245d4
to
5430f87
Compare
Builds ready [5430f87]
Page Load Metrics (2107 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the recording. LGTM.
Let's also get Salim to look this over since we are trying to sequence our PRs. Let's wait for his approval before merging it 👍
Builds ready [c8e2452]
Page Load Metrics (1797 ± 83 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
The base branch was changed.
e130366
to
a2c3a7d
Compare
Builds ready [a2c3a7d]
Page Load Metrics (1994 ± 75 ms)
Bundle size diffs
|
Description
This PR fixes the display in the asset page and in the main token list when the price checker setting is off
Related issues
Fixes: #28594
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2024-11-21.at.18.16.39.mov
Pre-merge author checklist
Pre-merge reviewer checklist