chore: Bump Snaps packages #28557
Merged
chore: Bump Snaps packages #28557
+74
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
Builds ready [345fbe3]
Page Load Metrics (2026 ± 86 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
## **Description** This PR adds support for the `Address` component in the `Card` title following this PR: MetaMask/snaps#2894 [](https://codespaces.new/MetaMask/metamask-extension/pull/28539?quickstart=1) ## **Related issues** ## **Manual testing steps** ```jsx <Card image='foo' title={<Address address={your address in MetaMask} displayName avatar={false} />} description='bar' extra='foobar' /> ``` ## **Screenshots/Recordings**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
GuillaumeRx
approved these changes
Nov 20, 2024
Builds ready [7545970]
Page Load Metrics (2128 ± 91 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Mrtenz
approved these changes
Nov 20, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/28539?quickstart=1){kind=link}
metamaskbot
added
the
release-12.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Snaps packages and handle any required changes.
Summary of Snaps changes:
AddressinCardtitlefetchresponses an instance ofResponseisSecureContextglobalarrayBufferfor fetching local Snaps