feat: token autodetection multi chain #28553

salimtb · 2024-11-19T23:03:07Z

Description

TokenDetectionController is responsible for detecting and keeping an updated list of all tokens across supported chains. This dataset is stored in the detectedTokens state variable within Metamask’s state. After completing this task, token detection will be enhanced by implementing periodic polling across all networks linked to the wallet, resulting in a more comprehensive dataset available to users.

For each network added to the wallet, the polling loop will receive the network as a parameter and execute token autodetection for it. Once results are available, they will be stored in detectedTokensAllChains, organized by chainId. This approach enables us to retrieve a comprehensive list of detected tokens across all networks.

Related issues

Fixes: #3431

Manual testing steps

install dependencies using yarn
start the project using PORTFOLIO_VIEW=1 yarn start
add other networks where you have tokens
the autodetection should be multichain

Screenshots/Recordings

Before

After

Screen.Recording.2024-11-08.at.14.27.23.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-19T23:03:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-20T10:22:42Z

Builds ready [817e528]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1865 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1654	2139	1874	128	61
		domContentLoaded	1643	2056	1836	117	56
		load	1652	2148	1865	132	63
		domInteractive	28	116	41	19	9
		backgroundConnect	8	88	28	23	11
		firstReactRender	46	296	124	80	38
		getState	46	198	111	42	20
		initialActions	0	1	0	0	0
		loadScripts	1218	1591	1383	101	48
		setupStore	6	82	18	26	13
		uiStartup	1980	2694	2280	228	110

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.45 KiB (0.02%)
common: 354 Bytes (0.00%)

ui/components/multichain/detected-token-banner/detected-token-banner.js

ui/hooks/useTokenFiatAmount.js

sahar-fehri · 2024-11-20T11:09:09Z

Left couple questions 🙏 Did QA on this looks good!

salimtb · 2024-11-20T11:51:58Z

@metamaskbot update-policies

sahar-fehri · 2024-11-20T11:52:09Z

One thing i noticed, is that when i am on a network and i import a token on another network; you would see the import notification but you wont see the token you just imported because its on a different network;
Is it worth updating the import msg to indicate the network where the token was imported?

metamaskbot · 2024-11-20T12:03:40Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

salimtb · 2024-11-20T12:26:32Z

@metamaskbot update-policies

metamaskbot · 2024-11-20T12:38:22Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2024-11-20T14:28:52Z

Builds ready [5d51658]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2080 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	418	2783	2002	421	202
		domContentLoaded	1750	2776	2055	211	101
		load	1759	2780	2080	211	101
		domInteractive	28	251	55	50	24
		backgroundConnect	6	74	30	24	11
		firstReactRender	56	303	147	90	43
		getState	42	191	114	44	21
		initialActions	0	1	0	0	0
		loadScripts	1297	2024	1542	156	75
		setupStore	6	83	12	16	8
		uiStartup	2184	3044	2541	253	121

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.64 KiB (0.03%)
common: 511 Bytes (0.01%)

metamaskbot · 2024-11-20T18:17:15Z

Builds ready [8194330]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2041 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	346	2491	1957	402	193
		domContentLoaded	1788	2479	2003	155	74
		load	1798	2493	2041	162	78
		domInteractive	30	252	58	48	23
		backgroundConnect	10	109	35	32	16
		firstReactRender	64	150	91	19	9
		getState	46	115	89	18	9
		initialActions	0	0	0	0	0
		loadScripts	1301	1917	1509	139	67
		setupStore	6	11	8	1	1
		uiStartup	2081	2822	2351	187	90

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.75 KiB (0.02%)
common: 506 Bytes (0.01%)

ui/components/app/detected-token/detected-token.js

.yarn/patches/@metamask-assets-controllers-npm-44.0.0-c223d56176.patch

.storybook/test-data.js

bergeron · 2024-11-20T21:07:04Z

Tested with and without PORTFOLIO_VIEW=1, detections and imports worked as expected

bergeron · 2024-11-20T21:11:18Z

here's a unit test fix: 954ca55

salimtb · 2024-11-20T21:13:21Z

954ca55

yes just pushed

metamaskbot · 2024-11-20T22:04:42Z

Builds ready [ba2c169]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2085 ± 133 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	311	2928	1995	471	226
		domContentLoaded	1823	2810	2048	256	123
		load	1840	2939	2085	278	133
		domInteractive	27	194	51	35	17
		backgroundConnect	8	128	33	28	13
		firstReactRender	54	292	103	65	31
		getState	52	189	94	33	16
		initialActions	0	0	0	0	0
		loadScripts	1313	2220	1537	225	108
		setupStore	6	12	8	2	1
		uiStartup	2075	3476	2431	392	188

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.61 KiB (0.02%)
common: 513 Bytes (0.01%)

metamaskbot · 2024-11-21T08:59:58Z

Builds ready [a48805c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2545 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	377	2874	2100	847	407
		domContentLoaded	2079	2911	2512	205	98
		load	2140	2922	2545	208	100
		domInteractive	41	101	63	19	9
		backgroundConnect	8	153	40	32	15
		firstReactRender	101	302	169	44	21
		getState	5	85	26	23	11
		initialActions	0	1	0	0	0
		loadScripts	1525	2252	1895	179	86
		setupStore	8	57	18	14	7
		uiStartup	2397	3634	2890	328	158

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 251 Bytes (0.00%)
ui: 1.73 KiB (0.02%)
common: 513 Bytes (0.01%)

metamaskbot · 2024-11-21T13:28:43Z

Builds ready [0cafd75]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1873 ± 149 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	354	3104	1721	538	258
		domContentLoaded	1615	3084	1845	299	144
		load	1630	3164	1873	311	149
		domInteractive	24	200	70	46	22
		backgroundConnect	8	78	28	20	10
		firstReactRender	65	204	114	27	13
		getState	4	61	16	19	9
		initialActions	0	0	0	0	0
		loadScripts	1160	2251	1371	220	106
		setupStore	6	12	7	1	1
		uiStartup	1845	3400	2085	319	153

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.98 KiB (0.03%)
common: 709 Bytes (0.01%)

metamaskbot added the team-assets label Nov 19, 2024

salimtb force-pushed the salim/token-autodetection-multi-chain branch from 615178a to e1f4656 Compare November 19, 2024 23:05

salimtb changed the title ~~Salim/token autodetection multi chain~~ feat: token autodetection multi chain Nov 19, 2024

salimtb force-pushed the salim/token-autodetection-multi-chain branch 3 times, most recently from b5a9b82 to 26be2ad Compare November 19, 2024 23:20

sahar-fehri reviewed Nov 20, 2024

View reviewed changes

ui/components/multichain/detected-token-banner/detected-token-banner.js Show resolved Hide resolved

salimtb marked this pull request as ready for review November 20, 2024 10:52

salimtb requested review from a team as code owners November 20, 2024 10:52

sahar-fehri reviewed Nov 20, 2024

View reviewed changes

ui/hooks/useTokenFiatAmount.js Show resolved Hide resolved

salimtb force-pushed the salim/token-autodetection-multi-chain branch from 83f706b to 23ec4ee Compare November 20, 2024 11:49

metamaskbot requested a review from a team as a code owner November 20, 2024 12:03

salimtb requested a review from a team as a code owner November 20, 2024 13:46

salimtb removed request for a team November 20, 2024 17:18

gambinish reviewed Nov 20, 2024

View reviewed changes

ui/components/app/detected-token/detected-token.js Outdated Show resolved Hide resolved

gambinish previously approved these changes Nov 20, 2024

View reviewed changes

bergeron reviewed Nov 20, 2024

View reviewed changes

.yarn/patches/@metamask-assets-controllers-npm-44.0.0-c223d56176.patch Outdated Show resolved Hide resolved

bergeron reviewed Nov 20, 2024

View reviewed changes

.storybook/test-data.js Outdated Show resolved Hide resolved

vinnyhoward previously approved these changes Nov 20, 2024

View reviewed changes

salimtb dismissed vinnyhoward’s stale review via 89a2f7f November 20, 2024 20:56

bergeron previously approved these changes Nov 20, 2024

View reviewed changes

salimtb dismissed bergeron’s stale review via 1551047 November 20, 2024 21:12

vinnyhoward previously approved these changes Nov 20, 2024

View reviewed changes

bergeron previously approved these changes Nov 20, 2024

View reviewed changes

salimtb dismissed stale reviews from bergeron and vinnyhoward via ba2c169 November 20, 2024 21:33

vinnyhoward previously approved these changes Nov 20, 2024

View reviewed changes

bergeron previously approved these changes Nov 20, 2024

View reviewed changes

gambinish added the DO-NOT-MERGE Pull requests that should not be merged label Nov 20, 2024

This comment was marked as resolved.

Sign in to view

salimtb dismissed stale reviews from bergeron and vinnyhoward via 180037e November 21, 2024 08:23

salimtb removed the DO-NOT-MERGE Pull requests that should not be merged label Nov 21, 2024

salimtb requested review from vinnyhoward and gambinish November 21, 2024 08:23

salimtb force-pushed the salim/token-autodetection-multi-chain branch from ef4f2aa to 8325697 Compare November 21, 2024 12:53

feat: multichain token autodetection

0cafd75

salimtb force-pushed the salim/token-autodetection-multi-chain branch from 8325697 to 0cafd75 Compare November 21, 2024 12:55

salimtb requested a review from sahar-fehri November 21, 2024 13:07

vinnyhoward approved these changes Nov 21, 2024

View reviewed changes

salimtb closed this Nov 21, 2024

github-actions bot locked and limited conversation to collaborators Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: token autodetection multi chain #28553

feat: token autodetection multi chain #28553

salimtb commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

metamaskbot commented Nov 20, 2024

sahar-fehri commented Nov 20, 2024

salimtb commented Nov 20, 2024

sahar-fehri commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

salimtb commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

bergeron commented Nov 20, 2024

bergeron commented Nov 20, 2024

salimtb commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

This comment was marked as resolved.

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 21, 2024

feat: token autodetection multi chain #28553

feat: token autodetection multi chain #28553

Conversation

salimtb commented Nov 19, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 19, 2024

metamaskbot commented Nov 20, 2024

sahar-fehri commented Nov 20, 2024

salimtb commented Nov 20, 2024

sahar-fehri commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

salimtb commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

bergeron commented Nov 20, 2024

bergeron commented Nov 20, 2024

salimtb commented Nov 20, 2024

metamaskbot commented Nov 20, 2024

This comment was marked as resolved.

metamaskbot commented Nov 21, 2024

metamaskbot commented Nov 21, 2024