Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PortfolioView: Remove pausedChainIds from selector #28552

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 19, 2024

Description

After speaking with Infura, we no longer need this pausedChainIds property from the remote API.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. No manual testing, simply removing property and its tests

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 19, 2024 20:42
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing changed the title PortfolioView: Remove pausedChainIds from selector fix: PortfolioView: Remove pausedChainIds from selector Nov 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ff46ca1]
Page Load Metrics (2255 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19572713226418790
domContentLoaded19452532221315976
load19592627225517283
domInteractive33266564924
backgroundConnect10102332713
firstReactRender553011288842
getState472221145024
initialActions00000
loadScripts14391890166512560
setupStore682202311
uiStartup225833922699353169
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -76 Bytes (-0.00%)

@darkwing darkwing added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [e54668b]
Page Load Metrics (2077 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28324011821617296
domContentLoaded18732304203412962
load18942413207714168
domInteractive16227694723
backgroundConnect7104463215
firstReactRender51143822311
getState4811187168
initialActions01000
loadScripts13511769151312057
setupStore6461094
uiStartup21702874236818187
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -76 Bytes (-0.00%)

@darkwing darkwing added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit 8bcd777 Nov 21, 2024
75 checks passed
@darkwing darkwing deleted the pv-no-paused branch November 21, 2024 01:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants