-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PortfolioView: Remove pausedChainIds from selector #28552
Merged
Merged
+4
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
changed the title
PortfolioView: Remove pausedChainIds from selector
fix: PortfolioView: Remove pausedChainIds from selector
Nov 19, 2024
darkwing
force-pushed
the
pv-no-paused
branch
from
November 19, 2024 20:52
c2f7d8d
to
ff46ca1
Compare
Builds ready [ff46ca1]
Page Load Metrics (2255 ± 83 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
gambinish
approved these changes
Nov 20, 2024
bergeron
approved these changes
Nov 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 20, 2024
Builds ready [e54668b]
Page Load Metrics (2077 ± 68 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
7 tasks
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After speaking with Infura, we no longer need this
pausedChainIds
property from the remote API.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist