Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initial poc of number flow for currency display #28551

Closed
wants to merge 1 commit into from

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Nov 19, 2024

DO NOT MERGE

Description

This pull request introduces a new test implementation for the number flow library, focusing on its integration with the MetaMask currency display feature. The primary goals are to:

  1. Evaluate the library's performance under various scenarios to ensure responsiveness and efficiency.
  2. Assess its impact on accessibility, confirming compliance with best practices and usability for all users.

This test is experimental and should not be merged into the main branch until further validation.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

  1. Navigate to the currency settings page in MetaMask.
  2. Perform operations involving currency display conversions.
  3. Verify the following:
    • Performance benchmarks (loading times, transitions, etc.).
    • Accessibility features (keyboard navigation, screen reader compatibility).

Screenshots/Recordings

motion1080.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the changes.
  • Confirmed the PR addresses its goals without introducing regressions.
  • Validated accessibility and performance improvements with evidence.

@georgewrmarshall georgewrmarshall self-assigned this Nov 19, 2024
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 19, 2024 20:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Extension label Nov 19, 2024
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@number-flow/[email protected] None 0 20.4 kB maxbarvian
npm/[email protected] None 0 2.84 kB benmccann
npm/[email protected] None 0 47.9 kB maxbarvian

View full report↗︎

@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants