Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display '< 0.01' instead of '0.00' for the fiat value of networ… #28543

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Nov 19, 2024

…k fee

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3631

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screenshot 2024-11-19 at 14 31 24

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Nov 19, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Nov 19, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner November 19, 2024 14:27
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo changed the title Display '< 0.01' instead of '0.00' for the fiat value of networ… feat: Display '< 0.01' instead of '0.00' for the fiat value of networ… Nov 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [0d56e3b]
Page Load Metrics (3284 ± 720 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint504521421461395670
domContentLoaded1489541032521501721
load1498544432841500720
domInteractive1335514211254
backgroundConnect9143463919
firstReactRender4538316110550
getState762931346129
initialActions00000
loadScripts1048444025321233592
setupStore6215274622
uiStartup1769648638491797863
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.52 KiB (0.02%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit e3c6b29 Nov 22, 2024
77 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3631 branch November 22, 2024 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants