chore: Reduce E2E test jobs run on PRs

[Gudahtt]

Description

The number of E2E test jobs run on PRs has been reduced to save on CircleCI credits. We still run the "chrome MV3" test job, but the Firefox and "chrome MV2/webpack build" E2E test jobs are now only run on develop, master, and RC branches. This should result in huge CircleCI credit savings.

These jobs were chosen because it's uncommon for test failures or flakiness to manifest in these jobs without also appearing in the Chrome MV3 E2E test job, and this job represents the mmajority of our userbase (the Chrome MV2/webpack build is only used for development).

Related issues

This is intended to reduce credit usage. There is no linked issue.

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [5c5674c]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1813 ± 45 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	321	1983	1673	431	207
		domContentLoaded	1662	2039	1787	97	47
		load	1675	2056	1813	94	45
		domInteractive	25	70	36	12	6
		backgroundConnect	11	96	29	23	11
		firstReactRender	44	215	85	53	25
		getState	47	190	98	40	19
		initialActions	0	1	0	0	0
		loadScripts	1227	1512	1328	74	36
		setupStore	5	83	18	26	13
		uiStartup	1906	2670	2144	228	109

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [81e8828]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2092 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	334	2432	2012	421	202
		domContentLoaded	1813	2371	2066	166	80
		load	1821	2435	2092	174	83
		domInteractive	28	278	69	62	30
		backgroundConnect	8	91	29	22	10
		firstReactRender	58	106	81	14	7
		getState	49	104	86	16	8
		initialActions	0	1	0	0	0
		loadScripts	1352	1785	1562	135	65
		setupStore	6	18	9	3	1
		uiStartup	2133	2816	2376	193	93

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[seaona]

nit: maybe we can also apply the same filter to the prep-build-test-webpack job? It takes only ~1minute, so we won't save much from that, but in case you want to add it

[Gudahtt]

Good suggestion, I had the same thought as well. I wasn't sure though, as having the build might catch build errors that we would otherwise miss.

[seaona]

good point, yeah we won't win much from that change, compared to the information we can loose, so happy as it is 👍

[metamaskbot]

Builds ready [85eb67f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1918 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1719	2457	1921	151	73
		domContentLoaded	1710	2440	1889	150	72
		load	1719	2455	1918	152	73
		domInteractive	27	127	44	21	10
		backgroundConnect	9	85	29	23	11
		firstReactRender	46	91	65	14	7
		getState	44	99	79	19	9
		initialActions	0	1	0	0	0
		loadScripts	1242	1991	1433	150	72
		setupStore	6	47	10	9	4
		uiStartup	1955	2758	2167	167	80

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[hjetpoluru]

Code changes LGTM.

Depending on the monitoring of the develop branch and the flakiness report, the changes can be easily reverted if needed.