-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update cross-spawn
#28522
Merged
Merged
chore: Update cross-spawn
#28522
+9
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package `cross-spawn` has been updated to v7.0.6 to address a security advisory. The advisory doesn't impact our usage of this library, but it was easy to update. We had two usages of an older major version of this library in our dependency tree (v5), which were forced to v7 using a resolution. The only breaking changes in v6 and v7 were dropping support for older Node.js versions that are already below our minimum supported version. `cross-spawn` changelog: https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md Resolves GHSA-3xgq-45jj-v275
@metamaskbot update-policies |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
No policy changes |
jclancy93
approved these changes
Nov 18, 2024
Builds ready [0de286c]
Page Load Metrics (2139 ± 90 ms)
Bundle size diffs
|
danjm
approved these changes
Nov 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-extension-platform
team-wallet-framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package
cross-spawn
has been updated to v7.0.6 to address a security advisory. The advisory doesn't impact our usage of this library, but it was easy to update.We had two usages of an older major version of this library in our dependency tree (v5), which were forced to v7 using a resolution. The only breaking changes in v6 and v7 were dropping support for older Node.js versions that are already below our minimum supported version.
cross-spawn
changelog: https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.mdRelated issues
Resolves GHSA-3xgq-45jj-v275
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist