Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update cross-spawn #28522

Merged
merged 1 commit into from
Nov 18, 2024
Merged

chore: Update cross-spawn #28522

merged 1 commit into from
Nov 18, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 18, 2024

Description

The package cross-spawn has been updated to v7.0.6 to address a security advisory. The advisory doesn't impact our usage of this library, but it was easy to update.

We had two usages of an older major version of this library in our dependency tree (v5), which were forced to v7 using a resolution. The only breaking changes in v6 and v7 were dropping support for older Node.js versions that are already below our minimum supported version.

cross-spawn changelog: https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md

Open in GitHub Codespaces

Related issues

Resolves GHSA-3xgq-45jj-v275

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The package `cross-spawn` has been updated to v7.0.6 to address a
security advisory. The advisory doesn't impact our usage of this
library, but it was easy to update.

We had two usages of an older major version of this library in our
dependency tree (v5), which were forced to v7 using a resolution. The
only breaking changes in v6 and v7 were dropping support for older
Node.js versions that are already below our minimum supported version.

`cross-spawn` changelog: https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md

Resolves GHSA-3xgq-45jj-v275
@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 18, 2024

@metamaskbot update-policies

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 16.1 kB satazor

🚮 Removed packages: npm/[email protected]

View full report↗︎

@metamaskbot
Copy link
Collaborator

No policy changes

@Gudahtt Gudahtt marked this pull request as ready for review November 18, 2024 17:41
@Gudahtt Gudahtt requested a review from a team as a code owner November 18, 2024 17:41
@metamaskbot
Copy link
Collaborator

Builds ready [0de286c]
Page Load Metrics (2139 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint18762681214419192
domContentLoaded18622593210917081
load18722692213918790
domInteractive318346157
backgroundConnect997322512
firstReactRender572051005225
getState492661185124
initialActions01000
loadScripts13752016159115173
setupStore77918199
uiStartup217132492532287138
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@Gudahtt Gudahtt added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@Gudahtt Gudahtt added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@Gudahtt Gudahtt added this pull request to the merge queue Nov 18, 2024
Merged via the queue into develop with commit ee75939 Nov 18, 2024
85 checks passed
@Gudahtt Gudahtt deleted the update-cross-spawn branch November 18, 2024 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants