-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make QR scanner more strict #28521
Merged
Merged
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [84f9979]
Page Load Metrics (2137 ± 50 ms)
Bundle size diffs
|
jclancy93
approved these changes
Nov 18, 2024
I manually tested on v12.6.1 and repro'd the bug, and then tested on this branch and saw the same as the above video. I also reviewed the code |
danjm
approved these changes
Nov 18, 2024
7 tasks
The QR scanner is now more strict about the contents it allows to be scanned. If the scanned QR code deviates at all from the supported formats, it will retur "unknown" as the result (as it always has for completely unrecognized QR codes). Previously we would accept QR codes with a recognized prefix even if the complete contents did not match our expectations, which has resulted in unexpected behavior.
Gudahtt
force-pushed
the
strict-qr-scanner
branch
from
November 18, 2024 20:57
84f9979
to
adc5f3c
Compare
Builds ready [adc5f3c]
Page Load Metrics (2150 ± 60 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The QR scanner is now more strict about the contents it allows to be scanned. If the scanned QR code deviates at all from the supported formats, it will return "unknown" as the result (as it always has for completely unrecognized QR codes).
Previously we would accept QR codes with a recognized prefix even if the complete contents did not match our expectations, which has resulted in unexpected behavior.
Related issues
Fixes #28527
Manual testing steps
Screenshots/Recordings
Before
We didn't record this, but multiple people on the team reproduced the problem.
After
https://www.loom.com/share/be8822e872a14ec98a47547cf6198603
Pre-merge author checklist
Pre-merge reviewer checklist