Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use PORTFOLIO_VIEW flag to determine chain polling #28504

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 15, 2024

Description

Updates the token price and detection hooks to only poll across chains when PORTFOLIO_VIEW is set.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. With PORTFOLIO_VIEW=1, requests should go to the price api across all chains.
  2. Without PORTFOLIO_VIEW=1, requests should go to the price api on the current chain.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron marked this pull request as ready for review November 15, 2024 23:27
@bergeron bergeron requested a review from a team as a code owner November 15, 2024 23:27
@metamaskbot
Copy link
Collaborator

Builds ready [9b99609]
Page Load Metrics (1892 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17262419191417584
domContentLoaded17042159186013263
load17182266189215172
domInteractive26266515024
backgroundConnect10159403617
firstReactRender492891216933
getState412021164823
initialActions01000
loadScripts12511635139010952
setupStore68114189
uiStartup198728102309236113
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 50 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bergeron bergeron enabled auto-merge November 16, 2024 00:37
gambinish
gambinish previously approved these changes Nov 20, 2024
sahar-fehri
sahar-fehri previously approved these changes Nov 20, 2024
@bergeron bergeron added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@bergeron bergeron added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@bergeron
Copy link
Contributor Author

bergeron commented Nov 20, 2024

I might have to fix a test since #28556 was introduced

@bergeron bergeron dismissed stale reviews from sahar-fehri and gambinish via a60bb7d November 20, 2024 19:01
@bergeron bergeron enabled auto-merge November 20, 2024 19:23
@metamaskbot
Copy link
Collaborator

Builds ready [a60bb7d]
Page Load Metrics (2050 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30327511806660317
domContentLoaded162326832011245118
load163227282050258124
domInteractive26187664220
backgroundConnect895372713
firstReactRender62207973818
getState44182903517
initialActions01000
loadScripts12002029151518589
setupStore67515178
uiStartup209432142384303145
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 50 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bergeron bergeron added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@bergeron bergeron added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@bergeron bergeron added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@bergeron bergeron added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 94a7b20 Nov 20, 2024
75 checks passed
@bergeron bergeron deleted the brian/portfolio-view-flag branch November 20, 2024 21:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants