Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix race condition validating ERC20 transfer (blockaid) (#28487) #28497

Closed
wants to merge 0 commits into from
Closed

fix: Fix race condition validating ERC20 transfer (blockaid) (#28487) #28497

wants to merge 0 commits into from
+0 −0

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Nov 15, 2024 •
edited by github-actions bot
Loading

Description

Cherry-pick #28487

Open in GitHub Codespaces

Related issues

Fixes: #28434

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Nov 15, 2024
@vinistevam vinistevam requested review from a team as code owners November 15, 2024 17:21
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cryptotavares
cryptotavares previously approved these changes Nov 15, 2024
View reviewed changes
Base automatically changed from Version-v12.7.0 to master November 15, 2024 17:31
@danjm danjm dismissed cryptotavares’s stale review November 15, 2024 17:31

The base branch was changed.

@danjm danjm closed this Nov 15, 2024
@danjm danjm force-pushed the cherry-pick-fix-race-condition-ppom-validation branch from d6339ae to 5561096 Compare November 15, 2024 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
@danjm
Copy link
Contributor

danjm commented Nov 15, 2024

replaced by #28500

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cryptotavares cryptotavares cryptotavares left review comments

Assignees
No one assigned
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinistevam @danjm @cryptotavares