Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix race condition validating ERC20 transfer (blockaid) #28487

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Nov 15, 2024

Description

Fixed race condition when validating ERC20 transfer and enabled ERC20 transfer blockaid e2e.

Open in GitHub Codespaces

Related issues

Fixes: #28434

Manual testing steps

  1. Go to this the test dapp
  2. Click and reject (fast ) all types of requests in the section: PPOM - Malicious Transactions and Signatures
  3. Should not get stuck in the loader

Screenshots/Recordings

Before

all.PPOM.signatures.webm

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam requested review from a team as code owners November 15, 2024 14:30
@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Nov 15, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added this pull request to the merge queue Nov 15, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [47a40ed]
Page Load Metrics (1917 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17362294191914871
domContentLoaded16982119187211656
load17372285191715474
domInteractive288943147
backgroundConnect8257445627
firstReactRender513211317737
getState4127263517
initialActions00000
loadScripts1254160513769947
setupStore582232512
uiStartup192930032217255123
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 11 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@vinistevam vinistevam added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@vinistevam vinistevam enabled auto-merge November 15, 2024 15:56
@vinistevam vinistevam added this pull request to the merge queue Nov 15, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [d8b5076]
Page Load Metrics (2118 ± 192 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42335802030539259
domContentLoaded161435242091397191
load161935362118399192
domInteractive156339115
backgroundConnect7100322613
firstReactRender533101336330
getState496282713
initialActions01000
loadScripts109929551550368177
setupStore55413136
uiStartup181138122403465223
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 11 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@vinistevam vinistevam added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@vinistevam vinistevam added this pull request to the merge queue Nov 15, 2024
Merged via the queue into develop with commit dbe5947 Nov 15, 2024
77 checks passed
@vinistevam vinistevam deleted the fix/race-condition-ppom-e2e-flaky branch November 15, 2024 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "PPOM Blockaid Alert - Malicious ERC20 Transfer @no-m..." flaky tests
4 participants