Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Resolve conflicts v12.7.0 with latest master #28468

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

hjetpoluru
Copy link
Contributor

@hjetpoluru hjetpoluru commented Nov 14, 2024

Description

Resolve conflicts in v12.7.0

Open in GitHub Codespaces

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot and others added 6 commits November 11, 2024 12:56
## **Description**

Add gas limit fix to changelog.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28410?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@hjetpoluru hjetpoluru added extension-delivery INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 14, 2024
@hjetpoluru hjetpoluru self-assigned this Nov 14, 2024
@hjetpoluru hjetpoluru requested a review from a team as a code owner November 14, 2024 19:30
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [a428b7d]
Page Load Metrics (1826 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15942089182113464
domContentLoaded15842040179212460
load15962094182614369
domInteractive1687502010
backgroundConnect9118292813
firstReactRender46281994823
getState568222411
initialActions01000
loadScripts11371536131811455
setupStore1194322512
uiStartup17982453204817484
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 881 Bytes (0.02%)
  • ui: 2.63 KiB (0.03%)
  • common: 902 Bytes (0.01%)

@danjm danjm merged commit 2ab2215 into Version-v12.7.0 Nov 15, 2024
75 checks passed
@danjm danjm deleted the resolve-conflicts-v12.7.0-master branch November 15, 2024 00:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants