Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cherry-pick): add simulation metrics when simulation UI is not visible (#28427) #28461

Merged

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Nov 14, 2024

Description

cherry pick PR #28427

Open in GitHub Codespaces

Related issues

Fixes: #28369

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

This PR adds transaction simulation metrics when the UI is not shown and
the transaction simulation settings is turned on

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28427?quickstart=1)

## **Related issues**

Fixes: #28369

## **Manual testing steps**
Turn on MetaMetrics settings

1. Go to wallet dashboard
2. Initiate send transaction directly through wallet
3. Reject or Cancel the transaction
4. Observe simulation metrics

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Vinicius Stevam <[email protected]>
Co-authored-by: Vinicius Stevam <[email protected]>
@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Nov 14, 2024
@vinistevam vinistevam requested a review from a team as a code owner November 14, 2024 16:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [3a7b260]
Page Load Metrics (1934 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16792545193819995
domContentLoaded16312435190218287
load16792497193419091
domInteractive31259664723
backgroundConnect975322412
firstReactRender52201953115
getState45418178
initialActions01000
loadScripts11831779139114570
setupStore1290312412
uiStartup183627422152219105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 881 Bytes (0.02%)
  • ui: 2.7 KiB (0.04%)
  • common: 902 Bytes (0.01%)

@hjetpoluru hjetpoluru merged commit b86383d into Version-v12.7.0 Nov 14, 2024
86 checks passed
@hjetpoluru hjetpoluru deleted the fix/cherry-pick-send-simulation-metrics-no-show branch November 14, 2024 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@sleepytanya
Copy link
Contributor

noSimulationsUI.mov
simulationsUI.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants