Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui customizations for redesigned transactions (#28443) #28457

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cryptotavares
Copy link
Contributor

Description

Cherry pick: 072c8c7

Open in GitHub Codespaces

Related issues

Fixes: #28322
Fixes: #28339

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28443?quickstart=1)

## **Related issues**

Fixes: #28322
Fixes: #28339

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Vinicius Stevam <[email protected]>
@cryptotavares cryptotavares requested review from a team as code owners November 14, 2024 14:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Nov 14, 2024
Copy link

sentry-io bot commented Nov 14, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/scripts/lib/transaction/metrics.ts

Function Unhandled Issue
buildEventFragmentProperties TypeError: null has no properties /background.html
Event Count: 21 Affected Users: 0
buildEventFragmentProperties SyntaxError: Invalid or unexpected token /scripts...
Event Count: 7 Affected Users: 0
buildEventFragmentProperties TypeError: Cannot destructure property 'name' of '(intermediate value)' as it is null. ...
Event Count: 5 Affected Users: 0
buildEventFragmentProperties TypeError: e.ᅦ槌ᅯ榫ᅤ槝iceModel is not a function /sc...
Event Count: 4 Affected Users: 0
buildEventFragmentProperties Error: e.ᅦ槌ᅯ榫ᅤ槝iceModel is not a function /notifi...
Event Count: 4 Affected Users: 0

Did you find this useful? React with a 👍 or 👎

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bee54dd]
Page Load Metrics (2542 ± 570 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint377477817531123539
domContentLoaded1575464325051179566
load1619474725421187570
domInteractive20211815225
backgroundConnect8108483115
firstReactRender454051268541
getState490182010
initialActions01000
loadScripts114336321886916440
setupStore116531199
uiStartup1772522528201335641
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 881 Bytes (0.02%)
  • ui: 2.63 KiB (0.03%)
  • common: 902 Bytes (0.01%)

@cryptotavares cryptotavares merged commit f0d2588 into Version-v12.7.0 Nov 14, 2024
76 checks passed
@cryptotavares cryptotavares deleted the fix/cherry-pick-28443 branch November 14, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants