Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove feature flag for multichain asset list #28450

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 13, 2024

Description

Remove the feature flag from Asset List Toggle such that we'd be merging and releasing the feature.

This is a PR to see how many E2Es break.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested review from a team as code owners November 13, 2024 23:20
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing force-pushed the remove-portfolio-view-fallout branch from f87cb81 to f3e278b Compare November 14, 2024 00:26
@darkwing darkwing force-pushed the remove-portfolio-view-fallout branch from c37ef5a to 944651a Compare November 14, 2024 01:18
@NidhiKJha NidhiKJha requested a review from a team as a code owner November 14, 2024 12:38
@NidhiKJha NidhiKJha closed this Nov 20, 2024
@NidhiKJha NidhiKJha deleted the remove-portfolio-view-fallout branch November 20, 2024 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@NidhiKJha NidhiKJha restored the remove-portfolio-view-fallout branch November 20, 2024 16:31
@NidhiKJha NidhiKJha reopened this Nov 20, 2024
@darkwing darkwing closed this Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants