Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update PortfolioView flag #28446

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: Update PortfolioView flag #28446

merged 1 commit into from
Nov 13, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 13, 2024

Description

Provides a more descriptive feature flag name

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 13, 2024 19:36
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing enabled auto-merge November 13, 2024 19:38
@darkwing darkwing added this pull request to the merge queue Nov 13, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [a5aa66c]
Page Load Metrics (1917 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17122362192113364
domContentLoaded16592207187011656
load17142378191714067
domInteractive247949199
backgroundConnect14168524019
firstReactRender55153962110
getState65718157
initialActions01000
loadScripts11841583137210249
setupStore65513147
uiStartup18752705211616881
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit 8a87315 Nov 13, 2024
85 checks passed
@darkwing darkwing deleted the update-pv-flag branch November 13, 2024 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-assets team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants