Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump assets controller to v43 and unlock multichain token detection and token list #28444

Closed

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 13, 2024

Description

This PR will upgrade the assets controller to version 43, enabling the multichain token auto-detection feature and adding new polling capabilities in the tokenListController. All multichain auto-detection changes are gated behind a feature flag.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. install dependencies using yarn
  2. start the project using PORTFOLIO_VIEW=1 yarn start
  3. add other networks where you have tokens
  4. the autodetection should be multichain

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the salim/multichain-token-detection-and-token-list branch from 0caba15 to b02e59d Compare November 13, 2024 17:51
Copy link

socket-security bot commented Nov 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@salimtb salimtb mentioned this pull request Nov 13, 2024
7 tasks
@salimtb salimtb force-pushed the salim/multichain-token-detection-and-token-list branch from b02e59d to a7c1e29 Compare November 13, 2024 17:56
@salimtb
Copy link
Contributor Author

salimtb commented Nov 13, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@salimtb salimtb force-pushed the salim/multichain-token-detection-and-token-list branch 2 times, most recently from fcab703 to a83472b Compare November 13, 2024 22:11
@salimtb salimtb closed this Nov 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants