Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui customizations for redesigned transactions #28443

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

cryptotavares
Copy link
Contributor

@cryptotavares cryptotavares commented Nov 13, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes: #28322
Fixes: #28339

Manual testing steps

  1. Go to this page...

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptotavares cryptotavares requested review from a team as code owners November 13, 2024 17:41
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Nov 13, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 13, 2024
@cryptotavares cryptotavares force-pushed the fix/redesign-ui-customization-metrics branch from 3d64b4f to 939aa80 Compare November 13, 2024 17:44
@metamaskbot
Copy link
Collaborator

Builds ready [b4577a5]
Page Load Metrics (2017 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41824781852493237
domContentLoaded17162412198918991
load17312489201720197
domInteractive175157410450
backgroundConnect11117272512
firstReactRender56115101168
getState45821199
initialActions01000
loadScripts12611881147215976
setupStore668262411
uiStartup194828282247222107
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 21 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@cryptotavares cryptotavares added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@cryptotavares cryptotavares added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@cryptotavares cryptotavares added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit 072c8c7 Nov 14, 2024
77 checks passed
@cryptotavares cryptotavares deleted the fix/redesign-ui-customization-metrics branch November 14, 2024 12:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-confirmations Push issues to confirmations team
Projects
None yet
5 participants