feat: Add first time interaction warning #28435

OGPoyraz · 2024-11-13T11:23:47Z

Description

This PR implements first time interaction feature where it shows an alert if you interact with the address for the first time.
Information of the first time interaction is fetched in the transaction controller when the transaction is added to the state.

Core PR: MetaMask/core#4895

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3040

Manual testing steps

Go to test dapp
Use send legacy transaction - make sure you interact here with your account for the first time
See warning

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

OGPoyraz · 2024-11-13T11:24:52Z

package.json

@@ -256,7 +256,8 @@
    "@ledgerhq/evm-tools/axios": "^0.28.0",
    "@ledgerhq/hw-app-eth/axios": "^0.28.0",
    "@ledgerhq/hw-app-eth@npm:^6.39.0": "patch:@ledgerhq/hw-app-eth@npm%3A6.39.0#~/.yarn/patches/@ledgerhq-hw-app-eth-npm-6.39.0-866309bbbe.patch",
-    "@ledgerhq/evm-tools@npm:^1.2.3": "patch:@ledgerhq/evm-tools@npm%3A1.2.3#~/.yarn/patches/@ledgerhq-evm-tools-npm-1.2.3-414f44baa9.patch"
+    "@ledgerhq/evm-tools@npm:^1.2.3": "patch:@ledgerhq/evm-tools@npm%3A1.2.3#~/.yarn/patches/@ledgerhq-evm-tools-npm-1.2.3-414f44baa9.patch",
+    "@metamask/transaction-controller@^38.3.0": "npm:@metamask-previews/[email protected]"


Reminder to not forget to remove preview version

…ddress-for-the-first-time

metamaskbot · 2024-11-22T09:52:58Z

Builds ready [b1764e7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2157 ± 130 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	365	3078	1889	663	318
		domContentLoaded	1715	2856	2101	254	122
		load	1735	3010	2157	272	130
		domInteractive	29	79	43	13	6
		backgroundConnect	9	176	45	38	18
		firstReactRender	60	294	128	77	37
		getState	48	284	129	68	33
		initialActions	0	1	0	0	0
		loadScripts	1275	2178	1591	204	98
		setupStore	6	79	21	26	12
		uiStartup	1994	3558	2608	436	209

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 89 Bytes (0.00%)
ui: 2.76 KiB (0.04%)
common: 6.78 KiB (0.08%)

app/scripts/metamask-controller.js

matthewwalsh0 · 2024-11-22T20:06:54Z

ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx

+                }}
+              >
+                {/* Intentional fragment */}
+                <></>


Minor, can we make the children optional within ConfirmInfoAlertRow or does this force some kind of spacing?

matthewwalsh0 · 2024-11-22T20:10:27Z

ui/pages/confirmations/hooks/alerts/transactions/useFirstTimeInteractionAlert.ts

+  const t = useI18nContext();
+  const { currentConfirmation } = useConfirmContext();
+
+  const { isFirstTimeInteraction } = currentConfirmation as TransactionMeta;


Minor, useConfirmContext accepts a template so we can avoid the cast.

matthewwalsh0 · 2024-11-22T20:20:02Z

app/_locales/en/messages.json

@@ -2091,6 +2091,12 @@
    "message": "File import not working? Click here!",
    "description": "Helps user import their account from a JSON file"
  },
+  "firstTimeInteractionReason": {


Minor, I think we try and standardise these with alertReasonX and alertMessageX.

Thanks for the heads up

matthewwalsh0 · 2024-11-22T20:20:33Z

ui/pages/confirmations/hooks/alerts/transactions/useFirstTimeInteractionAlert.test.ts

+    ).toEqual([]);
+  });
+
+  it('returns no alerts if firstTimeInteraction is false', () => {


Minor, is it worth an undefined test also?

…ddress-for-the-first-time

metamaskbot · 2024-11-26T10:05:54Z

Builds ready [2285d3c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1829 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	482	2235	1752	349	168
		domContentLoaded	1537	2192	1788	197	95
		load	1556	2241	1829	202	97
		domInteractive	25	88	43	21	10
		backgroundConnect	9	82	44	26	12
		firstReactRender	17	100	40	25	12
		getState	5	62	17	17	8
		initialActions	0	1	0	0	0
		loadScripts	1066	1696	1315	174	84
		setupStore	6	75	12	15	7
		uiStartup	1687	2569	2059	257	124

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 89 Bytes (0.00%)
ui: 1.72 KiB (0.02%)
common: 3.34 KiB (0.04%)

metamaskbot · 2024-11-26T12:00:05Z

Builds ready [8afa23c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1495 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	365	1758	1455	266	128
		domContentLoaded	1390	1670	1474	81	39
		load	1394	1696	1495	86	41
		domInteractive	21	68	38	18	8
		backgroundConnect	6	66	23	16	8
		firstReactRender	15	72	35	23	11
		getState	4	51	14	15	7
		initialActions	0	1	0	0	0
		loadScripts	995	1261	1085	71	34
		setupStore	6	60	11	15	7
		uiStartup	1535	1970	1659	110	53

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 89 Bytes (0.00%)
ui: 1.71 KiB (0.02%)
common: 3.34 KiB (0.04%)

…ddress-for-the-first-time

OGPoyraz · 2024-11-26T12:18:18Z

ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx

            style={{
              flexDirection: FlexDirection.Column,
-              alignItems: AlignItems.flexStart,


I've tested this to be sure, this is not needed.

metamaskbot · 2024-11-26T12:46:48Z

Builds ready [42ce181]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1706 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1443	2179	1705	172	83
		domContentLoaded	1426	2112	1670	161	77
		load	1464	2178	1706	170	82
		domInteractive	25	88	41	19	9
		backgroundConnect	9	125	38	28	13
		firstReactRender	17	77	43	22	11
		getState	5	69	18	19	9
		initialActions	0	1	0	0	0
		loadScripts	1029	1624	1232	132	64
		setupStore	6	57	11	11	5
		uiStartup	1638	2351	1890	173	83

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 89 Bytes (0.00%)
ui: 1.75 KiB (0.02%)
common: 3.34 KiB (0.04%)

metamaskbot · 2024-11-26T13:21:52Z

Builds ready [c60c010]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1724 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1521	2150	1727	144	69
		domContentLoaded	1478	2083	1691	139	67
		load	1510	2096	1724	142	68
		domInteractive	24	76	34	12	6
		backgroundConnect	9	69	34	17	8
		firstReactRender	16	80	27	17	8
		getState	4	59	21	19	9
		initialActions	0	1	0	0	0
		loadScripts	1062	1575	1232	116	56
		setupStore	6	52	15	16	8
		uiStartup	1679	2350	1918	166	80

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 89 Bytes (0.00%)
ui: 1.75 KiB (0.02%)
common: 3.34 KiB (0.04%)

metamaskbot · 2024-11-26T14:29:51Z

Builds ready [7801103]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1699 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1506	2024	1709	126	60
		domContentLoaded	1489	1956	1675	123	59
		load	1504	2029	1699	134	65
		domInteractive	26	87	45	20	9
		backgroundConnect	8	73	25	18	9
		firstReactRender	16	83	40	25	12
		getState	5	60	19	19	9
		initialActions	0	0	0	0	0
		loadScripts	1078	1451	1232	102	49
		setupStore	6	65	17	18	9
		uiStartup	1679	2219	1910	149	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 89 Bytes (0.00%)
ui: 1.75 KiB (0.02%)
common: 3.34 KiB (0.04%)

Add firstTimeInteraction feat

103affa

OGPoyraz requested review from a team as code owners November 13, 2024 11:23

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 13, 2024

OGPoyraz changed the title ~~Add firstTimeInteraction feat~~ feat: Add first time interaction warning Nov 13, 2024

OGPoyraz commented Nov 13, 2024

View reviewed changes

OGPoyraz added 3 commits November 19, 2024 10:57

Adjust latest version

bc0f58d

Merge branch 'develop' into 3040-alert-for-when-interacting-with-an-a…

5664076

…ddress-for-the-first-time

Adjust changes

b1764e7

matthewwalsh0 previously approved these changes Nov 22, 2024

View reviewed changes

OGPoyraz added 2 commits November 26, 2024 10:20

Merge branch 'develop' into 3040-alert-for-when-interacting-with-an-a…

02bf5eb

…ddress-for-the-first-time

Update package

9219001

OGPoyraz dismissed matthewwalsh0’s stale review via 9219001 November 26, 2024 09:21

OGPoyraz added 2 commits November 26, 2024 10:32

Fix suggestions

b257a27

remove unnecessary changes

2285d3c

OGPoyraz added 4 commits November 26, 2024 11:11

Final fixes

032e52e

Update snapshot

948190e

Update snapshot

70668c2

Fix lint

8afa23c

OGPoyraz added 3 commits November 26, 2024 13:08

Merge branch 'develop' into 3040-alert-for-when-interacting-with-an-a…

36bcb6a

…ddress-for-the-first-time

Update snapshot

4289e0d

Adjust latest changes

42ce181

OGPoyraz commented Nov 26, 2024

View reviewed changes

Update snapshots

c60c010

Fix tests

d5dde6a

Fix tests

7801103

OGPoyraz enabled auto-merge November 26, 2024 14:03

digiwand approved these changes Nov 26, 2024

View reviewed changes

matthewwalsh0 approved these changes Nov 26, 2024

View reviewed changes

OGPoyraz added this pull request to the merge queue Nov 26, 2024

Merged via the queue into develop with commit af9ebca Nov 26, 2024
75 checks passed

OGPoyraz deleted the 3040-alert-for-when-interacting-with-an-address-for-the-first-time branch November 26, 2024 15:04

github-actions bot locked and limited conversation to collaborators Nov 26, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add first time interaction warning #28435

feat: Add first time interaction warning #28435

OGPoyraz commented Nov 13, 2024 •

edited by github-actions bot

Loading

OGPoyraz Nov 13, 2024

OGPoyraz Nov 26, 2024

metamaskbot commented Nov 22, 2024

matthewwalsh0 Nov 22, 2024

OGPoyraz Nov 26, 2024

matthewwalsh0 Nov 22, 2024

OGPoyraz Nov 26, 2024

matthewwalsh0 Nov 22, 2024

OGPoyraz Nov 26, 2024

matthewwalsh0 Nov 22, 2024

OGPoyraz Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

OGPoyraz Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

feat: Add first time interaction warning #28435

feat: Add first time interaction warning #28435

Conversation

OGPoyraz commented Nov 13, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Nov 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

OGPoyraz commented Nov 13, 2024 •

edited by github-actions bot

Loading