-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Address design review for NFT token send #28433
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
08c5b18
to
b246755
Compare
Builds ready [b246755]
Page Load Metrics (2089 ± 81 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
b246755
to
edb1e52
Compare
edb1e52
to
74ff74f
Compare
Builds ready [74ff74f]
Page Load Metrics (2083 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@@ -13,7 +13,8 @@ const NFTTokenTransferInfo = () => { | |||
const { currentConfirmation: transactionMeta } = | |||
useConfirmContext<TransactionMeta>(); | |||
|
|||
const isWalletInitiated = transactionMeta.origin === 'metamask'; | |||
// const isWalletInitiated = transactionMeta.origin === 'metamask'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we uncomment this line and remove line 17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Builds ready [f1bb54f]
Page Load Metrics (2128 ± 88 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
A few changes were made, namely:
NftItem
component to display a square thumbnail of the Nft imageRelated issues
Fixes: #28370
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist