Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address design review for NFT token send #28433

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Nov 13, 2024

Description

A few changes were made, namely:

  • Leverage NftItem component to display a square thumbnail of the Nft image
  • Update spending cap indicators to abbreviate long decimal numbers and show complete numbers on a tooltip
  • Center align token name
  • Add # to the token id
  • Change background color for native token fallback thumbnail

Open in GitHub Codespaces

Related issues

Fixes: #28370

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Nov 13, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Nov 13, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners November 13, 2024 10:34
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/28370 branch 3 times, most recently from 08c5b18 to b246755 Compare November 13, 2024 14:27
@pedronfigueiredo pedronfigueiredo changed the title fix: Address design review fix: Address design review for NFT token send Nov 13, 2024
jpuri
jpuri previously approved these changes Nov 13, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b246755]
Page Load Metrics (2089 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint18422483209117082
domContentLoaded18152421205316278
load18422488208916881
domInteractive15238614723
backgroundConnect1069372110
firstReactRender77156107157
getState56215157
initialActions01000
loadScripts12851817150213565
setupStore65715178
uiStartup20512737230917182
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.28 KiB (0.02%)
  • common: 199 Bytes (0.00%)

jpuri
jpuri previously approved these changes Nov 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [74ff74f]
Page Load Metrics (2083 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36125081985415199
domContentLoaded17632386204918087
load17742529208319493
domInteractive318850168
backgroundConnect8141383014
firstReactRender5111777178
getState571691012211
initialActions01000
loadScripts12891824154315273
setupStore718932
uiStartup201031222398249119
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.37 KiB (0.02%)
  • common: 199 Bytes (0.00%)

jpuri
jpuri previously approved these changes Nov 19, 2024
@@ -13,7 +13,8 @@ const NFTTokenTransferInfo = () => {
const { currentConfirmation: transactionMeta } =
useConfirmContext<TransactionMeta>();

const isWalletInitiated = transactionMeta.origin === 'metamask';
// const isWalletInitiated = transactionMeta.origin === 'metamask';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we uncomment this line and remove line 17?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@metamaskbot
Copy link
Collaborator

Builds ready [f1bb54f]
Page Load Metrics (2128 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26225072037446214
domContentLoaded18072409208916881
load18132523212818388
domInteractive306644115
backgroundConnect8159403617
firstReactRender523181247938
getState502721205627
initialActions01000
loadScripts13301823157713866
setupStore6381073
uiStartup213231092552287138
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.39 KiB (0.02%)
  • common: 199 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 9605658 Nov 20, 2024
77 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/28370 branch November 20, 2024 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wallet and dApp initiated Send NFT confirmations
4 participants