ci: Fix attributions:check
silent failure
#28413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The script
attributions:check
was silently failing when the attempt to generate attributions failed. This led to the attributions in v12.6.0 being out-of-date.Related issues
Relates to #28412
Manual testing steps
yarn attributions:check
. See that the exit code is non-zerodevelop
it also fails, but with a zero exit code, indicating success despite the fact that it failed.Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist