Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix attributions:check silent failure #28413

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 11, 2024

Description

The script attributions:check was silently failing when the attempt to generate attributions failed. This led to the attributions in v12.6.0 being out-of-date.

Open in GitHub Codespaces

Related issues

Relates to #28412

Manual testing steps

  1. Run yarn attributions:check. See that the exit code is non-zero
    • on develop it also fails, but with a zero exit code, indicating success despite the fact that it failed.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The script `attributions:check` was silently failing when the attempt
to generate attributions failed. This led to the attributions in
v12.6.0 being out-of-date.

Relates to #28412
@Gudahtt Gudahtt marked this pull request as ready for review November 11, 2024 21:09
@Gudahtt Gudahtt requested review from kumavis and a team as code owners November 11, 2024 21:09
@metamaskbot
Copy link
Collaborator

Builds ready [cec7146]
Page Load Metrics (2051 ± 193 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint169636332050402193
domContentLoaded167436092016400192
load169436302051403193
domInteractive18238694622
backgroundConnect989362412
firstReactRender55168932613
getState587282211
initialActions01000
loadScripts118129761495372179
setupStore65915178
uiStartup191239182251419201
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added this pull request to the merge queue Nov 12, 2024
Merged via the queue into develop with commit ea00b02 Nov 12, 2024
85 checks passed
@Gudahtt Gudahtt deleted the fix-attributions-check-silent-failure branch November 12, 2024 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants