Multichain debug #28402

seaona · 2024-11-11T11:57:13Z

Description

List of failing tests:

Malicious Confirmation Signature - Bad Domain @no-mmi displays alert for domain binding and confirms
Malicious Confirmation Signature - Bad Domain @no-mmi initiates and rejects from confirmation screen
Malicious Confirmation Signature - Bad Domain @no-mmi initiates and rejects from alert friction modal
Malicious Confirmation Signature - Bad Domain @no-mmi displays alert for domain binding and confirms
Malicious Confirmation Signature - Bad Domain @no-mmi initiates and rejects from confirmation screen
Malicious Confirmation Signature - Bad Domain @no-mmi initiates and rejects from alert friction modal
smart transactions @no-mmi Completes a Swap
Simple Send Security Alert - Blockaid @no-mmi should not show security alerts for benign requests
Simple Send Security Alert - Blockaid @no-mmi should show security alerts for malicious requests
MultiRpc: should select rpc from modal
MetaMask onboarding @no-mmi doesn't make any network requests to infura before create new wallet onboarding is completed
MetaMask onboarding @no-mmi doesn't make any network requests to infura before onboarding by import is completed
MetaMask onboarding @no-mmi doesn't make any network requests to infura before create new wallet onboarding is completed
MetaMask onboarding @no-mmi doesn't make any network requests to infura before onboarding by import is completed

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Swaps

swaps-balance.mp4

ENS

ens-balance.mp4

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-11T11:57:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

seaona · 2024-11-13T08:39:28Z

test/e2e/tests/transaction/ens.spec.ts


        // click send button on homepage to start send flow
        const homepage = new HomePage(driver);
        await homepage.check_pageIsLoaded();
-        await homepage.check_expectedBalanceIsDisplayed('<0.000001');
+        await homepage.check_expectedBalanceIsDisplayed('20');


the mock adds more balance, so we are able to perform a send to ENS in the future

seaona · 2024-11-13T08:39:51Z

test/e2e/tests/transaction/ens.spec.ts

      ['eth_chainId', { result: `0x${chainId}` }],
+      // 1. Get the address of the resolver for the specified node


added some documentation and variables to make the ENS mocks more explicit

seaona · 2024-11-13T08:40:19Z

test/e2e/tests/transaction/ens.spec.ts

-          result: {},
-        },
-      }));
+    await mockMultiNetworkBalancePolling(mockServer);


polling balance mocks are extracted in this new function, this way we'll be able to use it in other tests

…o multichain-debug

seaona · 2024-11-13T11:03:52Z

test/e2e/tests/ppom/ppom-blockaid-alert-simple-send.spec.js

  await mockServerJsonRpc(mockServer, [
    ['eth_blockNumber'],
    ['eth_call'],
    ['eth_estimateGas'],
    ['eth_feeHistory'],
    ['eth_gasPrice'],
-    ['eth_getBalance'],


not needed, as we are mocking the balances using the mockMultiNetworkBalancePolling

seaona · 2024-11-13T11:04:09Z

test/e2e/tests/smart-transactions/mock-requests-for-swap-test.ts

-      id: 3806592044086814,
-      jsonrpc: '2.0',
-      result: '0x1bc16d674ec80000', // 2 ETH
-    });


not needed, as we are mocking the balances using the mockMultiNetworkBalancePolling

seaona · 2024-11-13T11:07:04Z

test/e2e/tests/smart-transactions/smart-transactions.spec.ts

  await withFixtures(
    {
-      fixtures: new FixtureBuilder({ inputChainId })


this is not needed and creates a miss-match with networks, causing to send network requests to localhost
we are using the fitxutre withEthereumMainnet, so we shouldn't change anything from the localhost default fixture

https://github.com/MetaMask/metamask-extension/blob/develop/test/e2e/default-fixture.js#L174

(I think we should also remove this from the default fixture to avoid future network miss-matches, but we can leave this out of scope from this PR)

metamaskbot · 2024-11-13T17:41:59Z

Builds ready [30ba00e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2219 ± 190 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1796	3216	2225	397	190
		domContentLoaded	1783	3163	2185	380	182
		load	1796	3203	2219	395	190
		domInteractive	28	156	53	31	15
		backgroundConnect	10	112	32	26	12
		firstReactRender	93	528	173	108	52
		getState	5	74	24	22	11
		initialActions	0	1	0	0	0
		loadScripts	1293	2494	1637	318	153
		setupStore	6	65	17	19	9
		uiStartup	2079	3564	2597	458	220

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 142 Bytes (0.00%)
ui: 1.35 KiB (0.02%)
common: 305 Bytes (0.00%)

metamaskbot · 2024-11-13T17:48:25Z

Builds ready [30ba00e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2219 ± 190 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1796	3216	2225	397	190
		domContentLoaded	1783	3163	2185	380	182
		load	1796	3203	2219	395	190
		domInteractive	28	156	53	31	15
		backgroundConnect	10	112	32	26	12
		firstReactRender	93	528	173	108	52
		getState	5	74	24	22	11
		initialActions	0	1	0	0	0
		loadScripts	1293	2494	1637	318	153
		setupStore	6	65	17	19	9
		uiStartup	2079	3564	2597	458	220

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 142 Bytes (0.00%)
ui: 1.35 KiB (0.02%)
common: 305 Bytes (0.00%)

seaona added 2 commits November 11, 2024 12:54

debugging branch

4d1cbfa

remove extra things

32ac47b

seaona requested a review from a team as a code owner November 11, 2024 11:57

metamaskbot added the team-extension-platform label Nov 11, 2024

seaona added 8 commits November 11, 2024 12:57

remove

fcd2f22

up0date fixtures

616a971

remove debugger

fb4520d

changes

621c92e

default fixture

4962917

some clean up

8a71134

remove not needed fixtures

a1ec7fe

fix lint

a3e6510

seaona commented Nov 13, 2024

View reviewed changes

seaona and others added 3 commits November 13, 2024 09:41

remox extra mocks

00dcfee

complete swap, and ppom tests

911288c

Merge branch 'feat/multi-chain-for-account-tracker-controller-v2' int…

1a254c3

…o multichain-debug

seaona commented Nov 13, 2024

View reviewed changes

sahar-fehri added 2 commits November 13, 2024 15:23

fix: fix poll when wallet unlocked

2de5b84

fix: fix smart tx mock

30ba00e

sahar-fehri mentioned this pull request Nov 13, 2024

fix: account tracker controller with useMultiPolling #28277

Merged

7 tasks

sahar-fehri merged commit 9aff235 into feat/multi-chain-for-account-tracker-controller-v2 Nov 13, 2024
71 checks passed

sahar-fehri deleted the multichain-debug branch November 13, 2024 17:46

github-actions bot locked and limited conversation to collaborators Nov 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multichain debug #28402

Multichain debug #28402

seaona commented Nov 11, 2024 •

edited

Loading

github-actions bot commented Nov 11, 2024

seaona Nov 13, 2024

seaona Nov 13, 2024

seaona Nov 13, 2024

seaona Nov 13, 2024

seaona Nov 13, 2024

seaona Nov 13, 2024

metamaskbot commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

		['eth_chainId', { result: `0x${chainId}` }],
		// 1. Get the address of the resolver for the specified node

Multichain debug #28402

Multichain debug #28402

Conversation

seaona commented Nov 11, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 11, 2024

seaona Nov 13, 2024

Choose a reason for hiding this comment

seaona Nov 13, 2024

Choose a reason for hiding this comment

seaona Nov 13, 2024

Choose a reason for hiding this comment

seaona Nov 13, 2024

Choose a reason for hiding this comment

seaona Nov 13, 2024

Choose a reason for hiding this comment

seaona Nov 13, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

seaona commented Nov 11, 2024 •

edited

Loading