Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Branch off of "New Crowdin translations by Github Action" #28390

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Nov 8, 2024

This is a branch off of #26964, as of commit 3ec2e61
This will make it easier to merge the branch, which regularly has new commits pushed to it

This adds new translations from crowdin

@danjm danjm requested a review from a team as a code owner November 8, 2024 18:24
@danjm danjm changed the title New Crowdin translations by Github Action chore: Branch off of "New Crowdin translations by Github Action" Nov 8, 2024
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-extension-platform labels Nov 8, 2024
desi
desi previously approved these changes Nov 8, 2024
DDDDDanica
DDDDDanica previously approved these changes Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@desi desi enabled auto-merge November 8, 2024 19:34
@desi
Copy link
Contributor

desi commented Nov 8, 2024

I have read the CLA Document and I hereby sign the CLA

@desi desi disabled auto-merge November 8, 2024 20:37
 - The app breaks if it can't parse the tokens correctly.
 - Should have been `$1 $2` vs `$1$2`
 - Has been fixed in crowdin as well so future pulls won't
   also be broken
@desi desi dismissed stale reviews from DDDDDanica and themself via 405f86d November 20, 2024 22:13
@metamaskbot
Copy link
Collaborator

Builds ready [82df47d]
Page Load Metrics (1770 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16152212177211957
domContentLoaded1574207617199947
load15822194177011656
domInteractive23203443919
backgroundConnect9108413014
firstReactRender503781449345
getState499342914
initialActions01000
loadScripts1123153412608541
setupStore583162010
uiStartup177124962069224108
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@desi desi added this pull request to the merge queue Nov 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [752dd20]
Page Load Metrics (1803 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22623131727393189
domContentLoaded15042249176316981
load15362318180318589
domInteractive135230115
backgroundConnect9157423617
firstReactRender721781022211
getState45718168
initialActions040294
loadScripts10671745130114871
setupStore56114168
uiStartup16892566200620598
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit aee0aa8 Nov 21, 2024
75 checks passed
@desi desi deleted the crowdin-PR-nov8 branch November 21, 2024 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants