-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multichain AssetList
#28386
Closed
gambinish
wants to merge
259
commits into
develop
from
feat/mmassets-432_network-filter-extension--integration-balances
+947
−364
Closed
feat: Multichain AssetList
#28386
Changes from all commits
Commits
Show all changes
259 commits
Select commit
Hold shift + click to select a range
6ec980b
chore: Merge main, address conflicts
gambinish 3b6d223
Merge branch 'develop' into feat/mmassets-432_network-filter-extension
gambinish d670862
Merge branch 'develop' into feat/mmassets-432_network-filter-extension
gambinish bf5913c
fix: Update unit tests in preferences-controller
gambinish 85d5161
feat: Add filterAssets function
gambinish 72ea2cf
chore: Polish filters to be layerable in order of importance, allowin…
gambinish 8b52780
fix: Lint tsc, specifiy chain indication rather than arbitrary number
gambinish 4349f4f
chore: Localize strings
gambinish 8b83df4
Merge branch 'develop' into feat/mmassets-432_network-filter-extension
gambinish bc82cb4
chore: Add localized Network string
gambinish 42ad7d4
Merge branch 'feat/mmassets-432_network-filter-extension' of github.c…
gambinish c4ce6c7
chore: Add FILTER_TOKENS_TOGGLE feature flag
gambinish 5be0713
Merge branch 'develop' into feat/mmassets-432_network-filter-extension
gambinish 023b0ca
fix: Show current selection on Network filter, and ellipsize when ove…
gambinish c9a2d8d
Merge branch 'feat/mmassets-432_network-filter-extension' of github.c…
gambinish ae96cea
fix: Lint
gambinish 5b40705
fix: Remove duplicate locale string
gambinish f7f09da
fix: Cleanup
gambinish 85fe12d
bump asset controllers to 39
bergeron 0f3cd64
update ConfirmTransaction
bergeron bdf921b
fix useGasFeeEstimates unit test
bergeron 9bc4ecf
fix usePolling tests
bergeron c6a408d
Merge branch 'develop' into feat/mmassets-432_network-filter-extension
gambinish 9b1529b
bump controller utils
bergeron c8bcc0b
remove patch
bergeron d1a3782
Merge branch 'develop' into brian/asset-controller-39
bergeron 05fd6ef
Update LavaMoat policies
metamaskbot 9dfdfa8
lint
bergeron 04ea3d6
Merge branch 'brian/asset-controller-39' of github.com:MetaMask/metam…
bergeron cf66072
Merge branch 'develop' into brian/asset-controller-39
bergeron 6934434
fix: Clean up filterAssets logic
gambinish 15e4e47
Merge branch 'feat/mmassets-432_network-filter-extension' of github.c…
gambinish a2074cd
fix: Update network-filter Avatar rendering logic
gambinish 6e80b34
Merge branch 'develop' into feat/mmassets-432_network-filter-extension
gambinish 836a11b
fix: Duplicate chainId
gambinish 441d4cf
Merge branch 'feat/mmassets-432_network-filter-extension' of github.c…
gambinish d18d25a
chore: Aggregate token listings across chains, per account
gambinish dd0b3f5
chore: Cleanup variables and logs
gambinish 1e461ee
Merge branch 'brian/asset-controller-39' into feat/mmassets-432_netwo…
gambinish a51fec4
chore: Update yarn resolution to provide marketData across chains
gambinish 0d637fb
chore: get balances for tokens via TokenTracker
gambinish c923dfe
feat: poc of consolidated asset view across chains. balances are mocked
gambinish 6a394a2
chore: Integrate filtering logic, to be improved
gambinish 785de28
initial multi chain polling for currency and token rates
bergeron f461767
fix testnets
bergeron f1da818
only refetch prices on chains whose tokens changed
bergeron 878f407
poll multiple native currencies
bergeron e8a9d6a
fix test
bergeron 245f8d3
yarn dedupe
bergeron 1afebee
Update LavaMoat policies
metamaskbot e99e2ef
Merge branch 'develop' into brian/currency-rate-multichain-polling2
bergeron ca590ec
fix e2e test mocks
bergeron d2191ac
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
bergeron 70c0db4
fix e2e test
bergeron 6b7df4d
.
bergeron 4e816c2
lint
bergeron aaef377
fix e2e test
bergeron 48bff46
Merge branch 'brian/currency-rate-multichain-polling2' of github.com:…
bergeron 0450b04
package.json
bergeron fdc04ad
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
bergeron 3ec3574
bump controller preview version
bergeron dcc8a64
Merge branch 'develop' into brian/multiexchangerate
bergeron 0e7a872
fix: fix lint
sahar-fehri ea95aca
fix: update js file to tsx
sahar-fehri 3bf7b78
Merge branch 'develop' into brian/multiexchangerate
sahar-fehri bb1f278
make polling input a chain id
bergeron 14dc84b
Merge branch 'develop' into brian/multiexchangerate
bergeron ef3ef10
bump to asset controller v42
bergeron ab6e7cc
.
bergeron 44861d9
Merge branch 'brian/multiexchangerate' of github.com:MetaMask/metamas…
bergeron 0b543e0
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
bergeron 411fc1c
initial token balances controller
bergeron c2b6afe
Update metamask-controller.js
bergeron 69404a5
Merge branch 'develop' into brian/token-balances-controller
bergeron bb1d6bf
cleanup
bergeron f6e56b3
Merge branch 'brian/token-balances-controller' of github.com:MetaMask…
bergeron 8e752a1
yarn
bergeron 6fac24b
feat: add native tokens to multichain token list (#28193)
jonybur 12570a5
chore: Merge develop, address conflicts
gambinish 39a1285
fix: Missed merge conflict in filter funciton
gambinish 95ce7de
fix: Address conflicts in lavamoat policies
gambinish f3a679b
fix: Address conflict in main lavamoat policy
gambinish b0c07c1
fix: Update selectors and various discrepancies after merge conflict …
gambinish 03e047d
fix: Incorrect selector for marketData
gambinish 3612b58
fix: Cleanup
gambinish 776c63b
fix: conversionRate undefined error on network switch
gambinish 9482953
fix: Get native token image from mapping
gambinish bd035f3
fix: Ethereum mainnet should be called Ethereum
gambinish 23747ed
fix: Changing selected network should reset filters to all networks
gambinish 14c9b57
fix: Cleanup selector console log
gambinish c308609
Styling changes
jonybur 3c9049c
fix: Add percentage change for native currency
gambinish f81cbbc
fix: Multichain scam warning should not appear on native tokens, othe…
gambinish 93cd913
fix: Network selector should also update network filter
gambinish f290926
fix: On mount, set the filters to show all networks by default
gambinish 919faf5
fix: Temporarily stub out showScamWarning boolean. To improve on mult…
gambinish 1710bc7
fix: pricePercentChange1d can be undefined, use optional chaining
gambinish ffe9e5f
fix: Tweak useEffect in asset-list-control-bar
gambinish 46bc93c
fix: Use tokenChainId not cached chainId from selected network
gambinish 5f0e632
Add auto switching for network on Send
jonybur f48e734
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
jonybur 25c8a90
Bugfixing, add tooltips
jonybur 06112af
chore: Temporarily link preview build of assets-controllers package
gambinish 56470ad
refactor: Init token balance integration
gambinish 42ce9be
Padding fixes
jonybur 6de2f95
UI fixes
jonybur ecb8508
Reduce size of selector
jonybur a241f5e
Fix native token clicking
jonybur 9509d36
chore: format currency and token values
gambinish b5a0642
chore: Handle native token balances
gambinish 41f19f2
refactor: Handle balance calculation higher up to respect sorting
gambinish ffa995b
fix: Include AssetsController patch
gambinish a58da57
chore: Cleanup
gambinish 65e2c18
chore: Tidy up some types on token-list
gambinish 3edf269
Fix toast for network switching
jonybur 2dc23d3
Fix asset page for offchain native tokens
jonybur d778834
Filter out zero-value tokens on asset list picker
jonybur 6537cb6
Design changes
jonybur ae73a3b
Fix: Consolidate type for AdressTokenMapping
gambinish 6397e30
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
gambinish 74f2b8e
chore: Fix calculated balances on asset details
gambinish 82d4c4e
chore: Render chart data for native token
gambinish 3cc8773
chore: Key market details on chainId
gambinish f73c8f4
chore: Cleanup market details
gambinish eea519f
chore: Cleanup types on token-list
gambinish ac3c389
Fix: small bug related to native token image
gambinish 3c2bc6b
fix: Remove console.log
gambinish 21bd89a
Fix: Include string in type
gambinish 3ff6b40
fix: Persist cross chain balances on detail view
gambinish e55852e
chore: formatWithThreshold
gambinish 929f406
chore: calculateTokenBalance utility
gambinish 5d06829
Create utilities for calculating tokenBalance and tokenFiatAmount
gambinish 39ec4e7
fix: Memoized token listing should update after new tokens are imported
gambinish 1d747e6
fix: Missing import
gambinish 9fe2f23
Add chain network switching for swaps and send on native tokens
jonybur 2691cb7
Fix toast on swap
jonybur 01c51de
Fix NaN value on new tokens
jonybur e82bb27
Remove console log
jonybur f1077cf
NFT fixes for multichain
jonybur 9b4b058
fix: Init zero balance bug
gambinish 9defc73
chore: Merge main, address conflicts
gambinish ed8cd61
fix: All networks filter should only show the chains for mainnet that…
gambinish 994b363
fix: Remove console.log
gambinish c5ddc71
fix: yarn lint
gambinish d5e56ec
fix: yarn lint:tsc
gambinish 776cecf
fix: Cleanup
gambinish 6a663a8
fix: If network icons doesn't exist, we should not fallback to the cu…
gambinish 7e2b157
fix: Show ETH as Ethereum on non ETH mainnet chains when allNetworks …
gambinish 5d07e03
fix: Lint
gambinish a7e2a77
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish 156482a
chore: Style updates to asset-list-control-bar
gambinish cd49ad1
chore: Update localization string in prep for multichain asset list
gambinish b4e4ba7
chore: Update import button to import icon in preparation for Multich…
gambinish d49824f
chore: Update sort control styles
gambinish 5c3d4d3
chore: Consider chainId when navigating from main asset list
gambinish 031e8e3
chore: Begin incorporating concept of chainId to support multichain a…
gambinish 40b36f5
fix: Tweak unit test
gambinish b24e25a
fix: Tweak unit test
gambinish 18aa7e8
chore: Add low risk selectors to prepare for multichain asset list
gambinish e127f07
fix: Add unit testable utility in preperation for unified asset list
gambinish 7307904
fix: Revert changes to locales, can't do this in advance
gambinish b5da71e
fix: Update test id in custom-token-add-approve.spec.js
gambinish e939574
chore: Remove console.log
gambinish c71bee0
fix: Update token-sort.spec.ts testid
gambinish f9fa8da
fix: Update other instances of testid Import
gambinish 1a1737a
chore: Add new unit test for findAssetByAddress util
gambinish 41adb56
fix: Update nullish search bug in chainSupprotsPricing
gambinish aa3063f
fix: Lint error in util.test.ts
gambinish 57f8af1
test: [POM] Migrate autodetect and import nft e2e tests to use Page O…
chloeYue 01652f5
test: fix state fixtures race condition (#28421)
seaona 02dba24
feat: btc send flow e2e (#28340)
montelaidev bc5f345
fix: Default to dApp suggested fees only when user selects the option…
pedronfigueiredo 0055289
Revert "fix: Lint error in util.test.ts"
gambinish c006bb6
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish 25c27ea
fix: @metamask/assets-controllers should be imported before local fil…
gambinish ce6f520
chore: Merge main, address conflicts
gambinish 6ceb087
chore: Merge in prep updates to reduces file size diff
gambinish dcf39fd
fix: Remove duplicate import entry for getCurrentChainId
gambinish 0ffa5d0
fix: Revert component library change to ButtonBase
gambinish 89b9ffc
fix: Revert margin update to ButtonBase
gambinish 8739893
fix: Continue using optional chaining in useFiatTokenBalance hook
gambinish 572f998
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish 82e1ddd
fix: Update token cell test, by tweaking primary formatWithThreshold …
gambinish 5ebc8e4
chore: tweak formatWithThreshold for primary token balance value
gambinish 5b684ad
fix: Update snapshot in token cell unit test
gambinish 21aa0c4
chore: Replace scam token warning logic in token-list-item
gambinish 11c51aa
chore: Tweak token-list-item isOriginalToken symbol prop
gambinish bc2f132
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish f474448
chore: Merge develop
gambinish a29b211
chore: Update legacy gas display unit test
gambinish 71c8879
fix: Remove suffix constraint
gambinish 4947aba
fix: Update snapshot
gambinish 5fa2984
fix: chore fix otudated snapshot
gambinish fc0722c
fix: Revert change to token cell snap
gambinish bf61b33
fix: Tweak snap
gambinish 04c3e3f
fix: troubleshoot whitespace diff
gambinish ae00656
fix: Troubleshoot whitespace diff
gambinish d18e085
fix: Troubleshoot whitespace diff
gambinish 43b0cfe
fix: Update showScamWarning to not scam native tokens on multichain t…
gambinish c147b3a
fix: Fix behavior of native token click
gambinish ae01bfc
chore: Merge develop, address conflicts
gambinish 9252c18
chore: Fix undefined bug during token import process causing crash
gambinish 35f6287
fix: When hex balance is 0x0, return zero value
gambinish 8e57813
fix: Cleanup console.log
gambinish e0b49ed
fix: Do not prematurely return from calculateTokenBalance function
gambinish 0a72a62
chore: Merge develop, address conflicts
gambinish 0bee071
fix: Patch updates and NetworkController:state change subscription
gambinish 2df22cb
refactor: Integrate useTokenBalances hook
gambinish 5c4c9b4
chore: Merge develop, address conflicts
gambinish 0e2c013
fix: Address inconsistencies after merge
gambinish 8bf9eaf
Style fixes
jonybur 1df49df
fix: Issue 28509 - when navigating to send/swap form a token from a c…
gambinish bc459c2
fix: Issue 28511 - Show native token symbol in token-list
gambinish 1fff579
fix: Issue 28513 - WHen a network is added, and the network is switch…
gambinish 5980212
fix: Issue 28513: Adding networks should toggle network filter
gambinish 758fa6a
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish 3b42f0c
Move refresh list to asset control bar
jonybur 2338fcc
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
jonybur a8364ff
Style fix
jonybur 4f70ccd
Filter tokens by test-nontest networks
jonybur da79b45
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish 836c2f5
fix: Dedupde controller polling init
gambinish 704fd6f
fix: typo in test id
gambinish 85546a0
fix: When new tokens are imported, rerender the token list
gambinish 3273dba
fix: On network change, include newly added network to tokenNetworkFi…
gambinish 1bdaf8d
fix: Format currency with same format as previous implementation to a…
gambinish 817c9ba
fix: Map Arbitrum, Linea, and Base native token to ETH logo
gambinish ce01c11
fix: Lint token-cell.tsx
gambinish e55b50d
chore: Merge develop, address conflicts
gambinish a9b16e2
fix: Remove fake loading boolean
gambinish 675780e
fix: Lint
gambinish 614b5ff
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish 0bbaeb5
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish 2c458c5
fix: Typo
gambinish 6e92ee4
chore: Rebase with develop
gambinish e6b33f5
fix: Revert removal of NativeToken in order to support flask build
gambinish 838e4a1
fix: Include nativeToken in props
gambinish 00c07aa
chore: Remove patch resolution
gambinish 5b7ea11
fix: Dont remove chokidar
gambinish 0d77e0b
fix: Dedupe controller method
gambinish d4880c7
fix: Align asset-list-control-bar styles
gambinish f0d722f
fix: component import
gambinish 035fb5c
fix: Revert token-cell test. Should be fixed in unit test branch, not…
gambinish 0867b5c
chore: Cleanup useAccountTotalFiatBalance hook
gambinish 7f29e11
Merge branch 'develop' into feat/mmassets-432_network-filter-extensio…
gambinish a610400
fix: Dont override suffix label
gambinish 650aec5
fix: Lint unused var
gambinish b34ce81
fix: React.CloneElement tells react to return an element in the tree
gambinish 006f12c
fix: Update en locale, loadingTokens no longer needed
gambinish 4d3aeba
fix: Temporarily log locale string to remove
gambinish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should refactor this logic into a hook. It's being used in multiple places, and should just use the
getChainIdsToPoll
selector.I would prefer to address this cleanup in a separate PR, if possible.