Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cherry-pick): gas limit estimation (#28327) #28378

Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 8, 2024

Description

Cherry-pick of #28327 for release 12.7.0.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Nov 8, 2024
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 8, 2024 11:33
@metamaskbot
Copy link
Collaborator

Builds ready [7565b64]
Page Load Metrics (1901 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint156425831906253121
domContentLoaded155524861874238114
load156525511901246118
domInteractive16109512411
backgroundConnect877322311
firstReactRender48134932110
getState46319209
initialActions01000
loadScripts111920221396214103
setupStore118021189
uiStartup176927562101267128
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 657 Bytes (0.01%)
  • ui: 2 KiB (0.03%)
  • common: 537 Bytes (0.01%)

@matthewwalsh0 matthewwalsh0 merged commit e33eebd into Version-v12.7.0 Nov 8, 2024
76 checks passed
@matthewwalsh0 matthewwalsh0 deleted the cherry-pick/28307-gas-limit-estimation-base branch November 8, 2024 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants