fix: Bug 28347 - Privacy mode tweaks (#28367)

[gambinish]

Description

Cherry pick of 82fdd64

Original PR: #28367

Privacy Mode should only effect PortfolioView and main account picker popover. It should not impact other areas of the App like Send/Swap/Gas because the toggle only exists on PortfolioView.

Related issues

Fixes: #28347

Manual testing steps

You can toggle privacyMode with eyeball on main PortfolioView

Should respect privacyMode:

1. Go to PortfolioView, toggling eyeball should show/hide balances for tokens as well as main balance
2. Go to AccountPicker from main Portfolio View, balances should hide/show
3. Go to AccountPicker from asset detail view, balances should hide/show

Should not respect privacyMode:

1. Go to AssetDetails, token balance should show on main page
2. Should not be respected on send/swap/gas screens
3. Balances should not be impacted elsewhere in the app. Please try to verify this while reviewing.

Screenshots/Recordings

Screen.Recording.2024-11-07.at.1.07.05.PM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [343c952]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1834 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1624	2308	1839	165	79
		domContentLoaded	1608	2220	1811	156	75
		load	1623	2310	1834	169	81
		domInteractive	16	125	49	26	13
		backgroundConnect	8	94	24	24	11
		firstReactRender	47	156	86	28	14
		getState	4	56	19	19	9
		initialActions	0	1	0	0	0
		loadScripts	1140	1645	1323	129	62
		setupStore	11	77	34	24	11
		uiStartup	1811	2554	2035	180	86

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 657 Bytes (0.01%)
• ui: 2 KiB (0.03%)
• common: 34 Bytes (0.00%)