Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick: chore: add the gas_included prop into Quotes Received event #28351

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 7, 2024

Description

Cherry pick of: #28295

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to Swaps on Ethereum mainnet
  2. Fill in the form with max ETH -> ERC20
  3. You will see in a network request that the new prop is there for the Quotes Requested event

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**
Adds the gas_included prop into Quotes Requested event in swaps.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28295?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to Swaps on Ethereum mainnet
2. Fill in the form with max ETH -> ERC20
3. You will see in a network request that the new prop is there for the
Quotes Requested event

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@dan437 dan437 requested a review from a team as a code owner November 7, 2024 12:43
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-transactions Transactions team label Nov 7, 2024
@dan437 dan437 added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Nov 7, 2024
@danjm danjm merged commit 4c3a355 into Version-v12.7.0 Nov 7, 2024
75 of 76 checks passed
@danjm danjm deleted the gas-included-prop-cherry-pick branch November 7, 2024 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b5eac8d]
Page Load Metrics (1829 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34821351611534257
domContentLoaded1684205618009747
load17002142182911153
domInteractive288049157
backgroundConnect784332412
firstReactRender46202873416
getState480202311
initialActions01000
loadScripts1236151213287938
setupStore1165302211
uiStartup18882419205814770
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 34 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants