Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent account sync from doing multiple syncs in parallel #28349

Closed

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Nov 7, 2024

This PR bumps @metamask/profile-sync-controller to its latest version. This version includes checks to prevent unwanted account syncs.

  • Prevent multiple parallel account sync processes
  • Prevent single operations if conditions aren't met

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mathieuartu mathieuartu added the team-notifications Notifications team label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mathieuartu mathieuartu closed this Nov 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@mathieuartu mathieuartu deleted the Version-v12.7.0-account-sync-improvements branch November 7, 2024 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant