-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (cherry-pick): incorrect standard swap gas fee estimation (#28127) #28191
Merged
matthewwalsh0
merged 1 commit into
Version-v12.6.0
from
fix/28088-cherry-pick-standard-swap-gas-fee-estimation
Oct 31, 2024
Merged
fix (cherry-pick): incorrect standard swap gas fee estimation (#28127) #28191
matthewwalsh0
merged 1 commit into
Version-v12.6.0
from
fix/28088-cherry-pick-standard-swap-gas-fee-estimation
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** Fix incorrect non-smart gas fee estimations due to the use of an empty estimated base fee. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28127?quickstart=1) ## **Related issues** Fixes: #28088 ## **Manual testing steps** See issue. ## **Screenshots/Recordings** ### **Before** ### **After** <img width="354" alt="Smart" src="https://github.com/user-attachments/assets/c1c604d3-9b03-4e4f-b819-9c21f230f789"> <img width="353" alt="Standard" src="https://github.com/user-attachments/assets/47acd4d1-c618-4d61-afdc-65ce827454a2"> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Builds ready [a6965ec]
Page Load Metrics (2202 ± 132 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
dbrans
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
matthewwalsh0
deleted the
fix/28088-cherry-pick-standard-swap-gas-fee-estimation
branch
October 31, 2024 09:06
metamaskbot
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Oct 31, 2024
No release label on PR. Adding release label release-12.6.0 on PR, as PR was cherry-picked in branch 12.6.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of PR #28127 for release 12.6.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist