-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ape token mainnet (#27974) #28013
Conversation
## **Description** PR to add Ape token icon and display ape icon for mainnet [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27974?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="1726" alt="Screenshot 2024-10-19 at 23 01 54" src="https://github.com/user-attachments/assets/57e66bce-db21-40d7-92de-00baaeb17187"> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/f8da7264-709b-4da2-85bd-b9dae6b1d724 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [20513b8]
Page Load Metrics (2115 ± 148 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@@ -207,6 +208,7 @@ export const CHAINLIST_CHAIN_IDS_MAP = { | |||
ZORA_MAINNET: '0x76adf1', | |||
FILECOIN: '0x13a', | |||
NUMBERS: '0x290b', | |||
APE: '0x8173', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is fine since it's a cherry pick. But CHAINLIST_CHAIN_IDS_MAP
already includes the spread operator ...CHAIN_IDS
so seems like it would already get the APE_MAINNET
entry from there?
Although I don't really know the difference between CHAIN_IDS
and CHAINLIST_CHAIN_IDS_MAP
anyway.
The base branch was changed.
Description
Cherry-picks b87b4e5
Adding apeChain mainnet chainId and token icon
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist