Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ape token mainnet (#27974) #28013

Closed
wants to merge 1 commit into from

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 22, 2024

Description

Cherry-picks b87b4e5

Adding apeChain mainnet chainId and token icon

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

PR to add Ape token icon and display ape icon for mainnet

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27974?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->
<img width="1726" alt="Screenshot 2024-10-19 at 23 01 54"
src="https://github.com/user-attachments/assets/57e66bce-db21-40d7-92de-00baaeb17187">

### **After**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/f8da7264-709b-4da2-85bd-b9dae6b1d724


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@sahar-fehri sahar-fehri requested a review from a team as a code owner October 22, 2024 16:26
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

salimtb
salimtb previously approved these changes Oct 22, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [20513b8]
Page Load Metrics (2115 ± 148 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35830192028489235
domContentLoaded176429372064260125
load178230252115308148
domInteractive18105552412
backgroundConnect10358557837
firstReactRender472931085325
getState5134253215
initialActions01000
loadScripts12731840151014369
setupStore12120483015
uiStartup201135332412440211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 152 Bytes (0.00%)

@@ -207,6 +208,7 @@ export const CHAINLIST_CHAIN_IDS_MAP = {
ZORA_MAINNET: '0x76adf1',
FILECOIN: '0x13a',
NUMBERS: '0x290b',
APE: '0x8173',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine since it's a cherry pick. But CHAINLIST_CHAIN_IDS_MAP already includes the spread operator ...CHAIN_IDS so seems like it would already get the APE_MAINNET entry from there?

Although I don't really know the difference between CHAIN_IDS and CHAINLIST_CHAIN_IDS_MAP anyway.

bergeron
bergeron previously approved these changes Oct 22, 2024
Base automatically changed from Version-v12.6.0 to master November 1, 2024 03:26
@danjm danjm dismissed stale reviews from bergeron and salimtb November 1, 2024 03:26

The base branch was changed.

@sahar-fehri sahar-fehri closed this Nov 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants