Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add B3 logo svg #27778

Merged
merged 3 commits into from
Dec 6, 2024
Merged

feat: add B3 logo svg #27778

merged 3 commits into from
Dec 6, 2024

Conversation

seangeng
Copy link
Contributor

@seangeng seangeng commented Oct 10, 2024

Description

Adding logo for the B3 network

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Go to add network

  1. Add B3 network (https://docs.b3.fun)
  2. B3 network should have a logo
  3. B3 token should have a logo

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seangeng seangeng requested a review from a team as a code owner October 10, 2024 19:40
Copy link
Contributor

github-actions bot commented Oct 10, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish
Copy link
Contributor

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA. ❌ @seangeng

@seangeng Can you please sign the CLA agreement as directed in this comment? I think this should help get some CI tests to pass.

@gambinish gambinish assigned gambinish and unassigned gambinish Oct 16, 2024
@seangeng
Copy link
Contributor Author

seangeng commented Dec 2, 2024

I have read the CLA Document and I hereby sign the CLA

@seangeng
Copy link
Contributor Author

seangeng commented Dec 2, 2024

@gambinish hey sorry this got lost - but I resolved the merge conflict + signed the CLA.

How's it look from here?

@gambinish gambinish enabled auto-merge December 6, 2024 01:49
@gambinish gambinish added this pull request to the merge queue Dec 6, 2024
Merged via the queue into MetaMask:main with commit 4112ff3 Dec 6, 2024
74 of 75 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants