Version v12.4.1 RC #27733

metamaskbot · 2024-10-09T17:09:25Z

📦 🚀

metamaskbot · 2024-10-09T17:45:10Z

Builds ready [13c758a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1918 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	161	2578	1755	561	270
		domContentLoaded	1592	2312	1885	176	85
		load	1599	2604	1918	213	102
		domInteractive	13	70	39	17	8

codecov · 2024-10-09T17:45:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (73ad771) to head (ac46289).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #27733      +/-   ##
==========================================
+ Coverage   70.07%   70.08%   +0.01%     
==========================================
  Files        1422     1423       +1     
  Lines       49702    49722      +20     
  Branches    13892    13898       +6     
==========================================
+ Hits        34827    34847      +20     
  Misses      14875    14875

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cherry-pick #27743 for v12.4.1 Co-authored-by: Mark Stacey <[email protected]>

github-actions · 2024-10-10T10:57:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-10-10T11:27:55Z

Builds ready [3d096c2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1761 ± 110 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1505	2484	1760	227	109
		domContentLoaded	1460	2369	1732	215	103
		load	1502	2496	1761	229	110
		domInteractive	17	245	48	48	23

…4.1 RC (#27757) ## **Description** Cherry picks swaps undefined object access crash hotfix intov12.4.1RC. See [here](#27708) for more info [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27757?quickstart=1) ## **Related issues** https://consensyssoftware.atlassian.net/jira/software/projects/MMS/boards/447/backlog?assignee=5ae37c7e42b8a62c4e15d92a&selectedIssue=MMS-1569 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Mark Stacey <[email protected]>

metamaskbot · 2024-10-10T13:49:43Z

Builds ready [3ebc8a7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1946 ± 113 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	228	2718	1791	561	269
		domContentLoaded	1563	2546	1919	195	94
		load	1572	2785	1946	235	113
		domInteractive	13	92	39	20	10

metamaskbot · 2024-10-10T19:51:22Z

Builds ready [ac46289]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1945 ± 147 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	307	2432	1732	499	240
		domContentLoaded	1620	2977	1910	297	143
		load	1629	2984	1945	305	147
		domInteractive	25	93	43	19	9

Version v12.4.1

13c758a

github-actions bot added the team-bot Bot team (for MetaMask Bot) label Oct 9, 2024

fix: remove old phishfort list from clients (#27743) (#27746)

3d096c2

Cherry-pick #27743 for v12.4.1 Co-authored-by: Mark Stacey <[email protected]>

Update CHANGELOG.md for v12.4.1 (#27775)

ac46289

danjm marked this pull request as ready for review October 10, 2024 19:51

danjm requested review from a team as code owners October 10, 2024 19:51

danjm approved these changes Oct 10, 2024

View reviewed changes

danjm merged commit ccb9706 into master Oct 10, 2024
80 checks passed

danjm deleted the Version-v12.4.1 branch October 10, 2024 19:52

github-actions bot locked and limited conversation to collaborators Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version v12.4.1 RC #27733

Version v12.4.1 RC #27733

metamaskbot commented Oct 9, 2024

metamaskbot commented Oct 9, 2024

codecov bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

Version v12.4.1 RC #27733

Version v12.4.1 RC #27733

Conversation

metamaskbot commented Oct 9, 2024

metamaskbot commented Oct 9, 2024

codecov bot commented Oct 9, 2024 • edited Loading

Codecov Report

github-actions bot commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

codecov bot commented Oct 9, 2024 •

edited

Loading