Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort and display all bridge quotes #27731

Merged
merged 25 commits into from
Nov 22, 2024
Merged

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Oct 9, 2024

Description

Changes

  • Fetch exchange rates on src/dest token selection
  • Calculate quote metadata and implement sorting
  • Create and style modal for displaying all bridge quotes
  • Autofill src token if navigating from asset page

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Request quotes
  2. View all quotes
  3. Toggle sorting and inspect output
  4. Verify that modal matches mocks
  5. Try selecting alternate quote

Screenshots/Recordings

Before

Mocks: https://www.figma.com/design/IuOIRmU3wI0IdJIfol0ESu/Cross-Chain-Swaps?node-id=1374-7239&m=dev

After

Screenshot 2024-11-12 at 5 08 49 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae force-pushed the mb891-fetch-bridge-quotes branch 4 times, most recently from 34753b0 to 3703e95 Compare October 16, 2024 18:27
@micaelae micaelae force-pushed the mb891-fetch-bridge-quotes branch 15 times, most recently from 0b78610 to 55aef81 Compare October 21, 2024 23:04
@micaelae micaelae force-pushed the mb891-sort-bridge-quotes branch from 8b9b803 to ec14842 Compare October 21, 2024 23:10
@micaelae micaelae force-pushed the mb891-fetch-bridge-quotes branch 2 times, most recently from becd686 to 71d4f47 Compare October 21, 2024 23:54
@micaelae micaelae force-pushed the mb891-sort-bridge-quotes branch from ec14842 to 28df490 Compare October 22, 2024 20:01
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@micaelae micaelae force-pushed the mb891-fetch-bridge-quotes branch 3 times, most recently from 92ff1e8 to 650bb36 Compare October 23, 2024 00:54
@micaelae micaelae force-pushed the mb891-sort-bridge-quotes branch from 28df490 to 919ffee Compare October 23, 2024 01:06
@micaelae micaelae force-pushed the mb891-sort-bridge-quotes branch from 7b21c13 to 6aa365d Compare November 22, 2024 19:25
@micaelae micaelae force-pushed the mb891-sort-bridge-quotes branch from 6aa365d to 47cdde0 Compare November 22, 2024 20:33
@metamaskbot
Copy link
Collaborator

Builds ready [47cdde0]
Page Load Metrics (1733 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39919251681306147
domContentLoaded1561188716987938
load1579195117339445
domInteractive197631147
backgroundConnect11111422412
firstReactRender641581022110
getState46113157
initialActions00000
loadScripts1127136012356230
setupStore65512136
uiStartup17722296193112459
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 874 Bytes (0.01%)
  • ui: 10.64 KiB (0.14%)
  • common: 6.59 KiB (0.08%)

@micaelae micaelae added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit 6eb7ccf Nov 22, 2024
75 checks passed
@micaelae micaelae deleted the mb891-sort-bridge-quotes branch November 22, 2024 22:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants