refactor: move getCurrentChainId from selectors/selectors.js to shared/modules/selectors/networks.ts

[davidmurdoch]

Converts the selector getCurrentChainId from functions from JS to TS and moves it to the shared folder. Also updates some functions to match the actual expect return values and fixes some types.

Why only this function? I'm trying to solve circular dependency issues. getCurrentChainId is so widely used in the codebase, it makes it very complicated to untangle. I've moved it to shared/modules/selectors/networks.ts

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [209dd01]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2031 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1702	2571	2028	215	103
		domContentLoaded	1650	2554	1994	210	101
		load	1699	2570	2031	211	101
		domInteractive	15	104	47	24	12

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -110 Bytes (-0.00%)
• ui: -94 Bytes (-0.00%)
• common: 4.21 KiB (0.06%)

[metamaskbot]

Builds ready [d640044]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1658 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1453	2100	1666	148	71
		domContentLoaded	1438	2036	1637	140	67
		load	1450	2103	1658	145	70
		domInteractive	22	101	45	23	11
		backgroundConnect	9	66	25	18	8
		firstReactRender	15	73	35	24	12
		getState	4	48	9	9	4
		initialActions	0	0	0	0	0
		loadScripts	1050	1538	1231	113	54
		setupStore	6	56	14	16	8
		uiStartup	1597	2328	1838	168	80

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -5 Bytes (-0.00%)
• ui: 5.68 KiB (0.07%)
• common: 969 Bytes (0.01%)