-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move getProviderConfig
out of ducks/metamask.js
to shared/selectors/networks.ts
#27646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
davidmurdoch
force-pushed
the
circles-007
branch
from
October 8, 2024 17:55
80e8075
to
47b0f89
Compare
davidmurdoch
force-pushed
the
circles-008
branch
from
October 8, 2024 17:56
7f150e4
to
aeb1e10
Compare
davidmurdoch
force-pushed
the
circles-007
branch
from
October 8, 2024 18:06
47b0f89
to
e6df46a
Compare
davidmurdoch
force-pushed
the
circles-008
branch
from
October 8, 2024 18:06
aeb1e10
to
ac769fa
Compare
davidmurdoch
force-pushed
the
circles-007
branch
from
October 8, 2024 20:59
e6df46a
to
77bdf73
Compare
davidmurdoch
force-pushed
the
circles-008
branch
from
October 8, 2024 22:49
ac769fa
to
90f4d55
Compare
davidmurdoch
added
the
team-tiger
Tiger team (for tech debt reduction + performance improvements)
label
Oct 9, 2024
davidmurdoch
changed the title
move
move Oct 9, 2024
getProviderConfig
out of ducks/metamask.js
to `selectors/net…getProviderConfig
out of ducks/metamask.js
to selectors/networks.ts
davidmurdoch
changed the title
move
chore: move Oct 9, 2024
getProviderConfig
out of ducks/metamask.js
to selectors/networks.ts
getProviderConfig
out of ducks/metamask.js
to selectors/networks.ts
davidmurdoch
changed the title
chore: move
refactor: move Oct 9, 2024
getProviderConfig
out of ducks/metamask.js
to selectors/networks.ts
getProviderConfig
out of ducks/metamask.js
to selectors/networks.ts
davidmurdoch
force-pushed
the
circles-008
branch
4 times, most recently
from
October 9, 2024 19:11
2341b7f
to
6f8db43
Compare
davidmurdoch
force-pushed
the
circles-007
branch
from
October 16, 2024 19:58
77bdf73
to
baca2f5
Compare
davidmurdoch
force-pushed
the
circles-008
branch
from
October 16, 2024 21:26
6f8db43
to
6737f10
Compare
davidmurdoch
force-pushed
the
circles-008
branch
from
October 16, 2024 22:32
6737f10
to
0c6f2a7
Compare
Quality Gate passedIssues Measures |
Builds ready [0c6f2a7]
Page Load Metrics (1738 ± 83 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
force-pushed
the
circles-007
branch
from
October 30, 2024 18:01
baca2f5
to
96d49b7
Compare
davidmurdoch
dismissed stale reviews from Prithpal-Sooriya, jclancy93, and FrederikBolding
via
November 21, 2024 15:10
3e54a1e
Gudahtt
previously approved these changes
Nov 21, 2024
ok |
davidmurdoch
requested review from
Prithpal-Sooriya,
jclancy93,
FrederikBolding and
shane-t
November 21, 2024 15:29
FrederikBolding
previously approved these changes
Nov 21, 2024
Builds ready [3e54a1e]
Page Load Metrics (2003 ± 133 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
dismissed stale reviews from FrederikBolding and Gudahtt
via
November 21, 2024 21:56
027ca07
Gudahtt
previously approved these changes
Nov 21, 2024
Builds ready [d1b2e6b]
Page Load Metrics (2027 ± 136 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
desi
approved these changes
Nov 21, 2024
darkwing
approved these changes
Nov 21, 2024
FrederikBolding
approved these changes
Nov 21, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-extension-platform
team-tiger
Tiger team (for tech debt reduction + performance improvements)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts some from functions from JS to TS. Also updates some functions to match the actual expect return values.
Why only these functions? I'm trying to solve circular dependency issues.
getProviderConfig
is so widely used in the codebase, and makes use of multiple selectors itself, it makes it very complicated to untangle. I've put it in a new file (seelctors/networks.ts
) just to, hopefully temporarily, simplify untangling other circular dependency issues.