Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick ab37660 (PR ##27543) to V12.4.0 #27577

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

k-g-j
Copy link
Contributor

@k-g-j k-g-j commented Oct 2, 2024

This PR cherry-picks the commit ab37660 (#27543) into the release v12.4.0

@k-g-j k-g-j requested review from a team as code owners October 2, 2024 17:24
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 2, 2024
@k-g-j k-g-j added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (bc08781) to head (949e1d1).

Files with missing lines Patch % Lines
...multichain/account-list-menu/account-list-menu.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.4.0   #27577      +/-   ##
===================================================
- Coverage            70.05%   70.05%   -0.00%     
===================================================
  Files                 1422     1422              
  Lines                49677    49677              
  Branches             13887    13887              
===================================================
- Hits                 34800    34799       -1     
- Misses               14877    14878       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm danjm merged commit c414b28 into Version-v12.4.0 Oct 2, 2024
75 of 76 checks passed
@danjm danjm deleted the v12.4.0/cherry-pick/ab37660 branch October 2, 2024 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [949e1d1]
Page Load Metrics (1741 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23122061593485233
domContentLoaded14852201171917785
load14992205174117584
domInteractive176132126

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants