Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix link in change entry #27508

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 30, 2024

Description

The "Fix notification metrics" change entry linked a PR where some of these metrics were originally introduced, but it should have linked the PR where they were fixed. The link has been updated.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The "Fix notification metrics" change entry linked a PR where some of
these metrics were originally introduced, but it should have linked the
PR where they were fixed. The link has been updated.
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (98a6968) to head (e3dcb18).

Additional details and impacted files
@@               Coverage Diff                @@
##           Version-v12.3.1   #27508   +/-   ##
================================================
  Coverage            70.15%   70.15%           
================================================
  Files                 1431     1431           
  Lines                50437    50437           
  Branches             13995    13995           
================================================
  Hits                 35380    35380           
  Misses               15057    15057           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e3dcb18]
Page Load Metrics (1808 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15912211182016177
domContentLoaded15412074176713867
load15902113180814770
domInteractive137036168

@Gudahtt Gudahtt marked this pull request as ready for review September 30, 2024 19:04
@Gudahtt Gudahtt requested a review from a team as a code owner September 30, 2024 19:04
@Gudahtt Gudahtt merged commit 2ede67e into Version-v12.3.1 Sep 30, 2024
77 of 78 checks passed
@Gudahtt Gudahtt deleted the v12.3.1-changelog-fix-link branch September 30, 2024 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants