Version v12.3.1 RC #27434
Merged
Version v12.3.1 RC #27434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [7e88180]
Page Load Metrics (1737 ± 52 ms)
|
… (#27435) This PR correctly applies the changes from #26807 and #26924 to master. These were broken, probably by careless human error, in 3e1094a --------- Co-authored-by: Matteo Scurati <[email protected]>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27434 +/- ##
==========================================
- Coverage 70.15% 70.15% -0.00%
==========================================
Files 1431 1431
Lines 50437 50437
Branches 13994 13995 +1
==========================================
- Hits 35381 35380 -1
- Misses 15056 15057 +1 ☔ View full report in Codecov by Sentry. |
Builds ready [5f93766]
Page Load Metrics (1739 ± 48 ms)
|
## **Description** Fixes issue [27456](#27456) in 12.3. If you try to add a new network with the same RPC URL and chain id as an existing network, the link presented in the error message does not work and throws an error: https://github.com/user-attachments/assets/ebcade54-e49e-4a04-9ed6-396f2458f77a This link in the error message was intended for the network redesign and should stay behind the feature flag. Duplicate chain IDs are allowed in this version of network managment. So this PR makes it back into a warning like it would have been in 12.2: <img width="338" alt="Screenshot 2024-09-27 at 12 02 49 PM" src="https://github.com/user-attachments/assets/8c114cf7-5a1d-4662-b84f-a74caaef08d8"> There's nothing to fix in develop since it is already on the new network controller / UI [](https://codespaces.new/MetaMask/metamask-extension/pull/27463?quickstart=1) ## **Related issues** Fixes: #27456 ## **Manual testing steps** 1. Try to add a new network with the same RPC URL and chain id as an existing network. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…ring error (#27457) (#27462) ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The original code assumes that getMethodData will always return an object with a name property. However, in certain instances, getMethodData can return null. When this happens, destructuring the name property from null causes a runtime error. To address this issue, the code has been updated to use optional chaining. This ensures that if getMethodData returns null, the destructuring will not occur, and contractMethodName will be set to undefined instead of causing an error. [](https://codespaces.new/MetaMask/metamask-extension/pull/27457?quickstart=1) ## **Related issues** Fixes: #27436 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Pedro Figueiredo <[email protected]>
Builds ready [31d1f14]
Page Load Metrics (1649 ± 68 ms)
|
## **Description** Update changelog for v12.3.1 [](https://codespaces.new/MetaMask/metamask-extension/pull/27465?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Builds ready [98a6968]
Page Load Metrics (1834 ± 130 ms)
|
Gudahtt
previously approved these changes
Sep 30, 2024
There was a problem hiding this comment.
- #27463: I tested this, and it works as expected
- #27435: I wasn't sure how to test this
- #27457: I wasn't sure how to test this, but the code changes are so minimal that it seems self-evidently safe to me, unable to cause a regression.
LGTM, though we should get someone to test and sign off on the notification metrics changes.
## **Description** The "Fix notification metrics" change entry linked a PR where some of these metrics were originally introduced, but it should have linked the PR where they were fixed. The link has been updated. [](https://codespaces.new/MetaMask/metamask-extension/pull/27508?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This was QA'd by @Prithpal-Sooriya and approved (communicated in Slack release thread) |
Gudahtt
approved these changes
Sep 30, 2024
Builds ready [2ede67e]
Page Load Metrics (1792 ± 133 ms)
|
](https://codespaces.new/MetaMask/metamask-extension/pull/27463?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27457?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27465?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27508?quickstart=1){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 🚀