-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Estimated fee in redesigned screens #27250
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> `maxFeePerGas`, `maxPriorityFeePerGas` and `estimatedBaseFee` are decimal values that should be converted before being used inside `multiplyHexes` and `addHexes`. `estimatedBaseFee` also needs to be converted to wei. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27247?quickstart=1) Fixes: 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <img width="320" alt="Screenshot 2024-09-18 at 13 40 13" src="https://github.com/user-attachments/assets/cf06ac39-6ab7-46c9-af84-951efbb37fd1"> <img width="320" alt="Screenshot 2024-09-18 at 13 39 49" src="https://github.com/user-attachments/assets/15c8ff6b-6277-4f7f-b290-68adb21d845a"> <img width="320" alt="Screenshot 2024-09-18 at 13 37 13" src="https://github.com/user-attachments/assets/6d4e3500-972e-4196-8041-8a16436daaf7"> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
59a7243
to
e2d73bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.3.0 #27250 +/- ##
===================================================
- Coverage 70.24% 70.12% -0.12%
===================================================
Files 1426 1431 +5
Lines 50239 50379 +140
Branches 13954 13978 +24
===================================================
+ Hits 35289 35327 +38
- Misses 14950 15052 +102 ☔ View full report in Codecov by Sentry. |
Builds ready [3fcbdd6]
Page Load Metrics (1899 ± 97 ms)
|
No release label on PR. Adding release label release-12.3.0 on PR, as PR was added to branch 12.3.0 when release was cut. |
cherry-pick: (#27247)
maxFeePerGas
,maxPriorityFeePerGas
andestimatedBaseFee
are decimal values that should be converted before being used insidemultiplyHexes
andaddHexes
.estimatedBaseFee
also needs to be converted to wei.Fixes:
I've followed MetaMask Contributor Docs and MetaMask Extension Coding
Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist