Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Estimated fee in redesigned screens #27250

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 18, 2024

cherry-pick: (#27247)

maxFeePerGas, maxPriorityFeePerGas and estimatedBaseFee are decimal values that should be converted before being used inside multiplyHexes and addHexes. estimatedBaseFee also needs to be converted to wei.

Open in GitHub Codespaces

Fixes:

  1. Go to this page... 2.
Screenshot 2024-09-18 at 13 40 13 Screenshot 2024-09-18 at 13 39 49 Screenshot 2024-09-18 at 13 37 13
  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding
    Standards
    .

  • I've completed the PR template to the best of my ability

  • I’ve included tests if applicable

  • I’ve documented my code using JSDoc format if applicable

  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

`maxFeePerGas`, `maxPriorityFeePerGas` and `estimatedBaseFee` are
decimal values that should be converted before being used inside
`multiplyHexes` and `addHexes`. `estimatedBaseFee` also needs to be
converted to wei.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27247?quickstart=1)

Fixes:

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<img width="320" alt="Screenshot 2024-09-18 at 13 40 13"
src="https://github.com/user-attachments/assets/cf06ac39-6ab7-46c9-af84-951efbb37fd1">

<img width="320" alt="Screenshot 2024-09-18 at 13 39 49"
src="https://github.com/user-attachments/assets/15c8ff6b-6277-4f7f-b290-68adb21d845a">

<img width="320" alt="Screenshot 2024-09-18 at 13 37 13"
src="https://github.com/user-attachments/assets/6d4e3500-972e-4196-8041-8a16436daaf7">

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 18, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 18, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners September 18, 2024 14:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo changed the title cherry-pick: fix: Estimated fee in redesigned screens (#27247) fix: Estimated fee in redesigned screens Sep 18, 2024
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/cherry-pick-gas-fixes branch from 59a7243 to e2d73bf Compare September 18, 2024 14:40
jpuri
jpuri previously approved these changes Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (439f7d6) to head (3fcbdd6).
Report is 14 commits behind head on Version-v12.3.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27250      +/-   ##
===================================================
- Coverage            70.24%   70.12%   -0.12%     
===================================================
  Files                 1426     1431       +5     
  Lines                50239    50379     +140     
  Branches             13954    13978      +24     
===================================================
+ Hits                 35289    35327      +38     
- Misses               14950    15052     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [3fcbdd6]
Page Load Metrics (1899 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27923601823405195
domContentLoaded16162304186118790
load16292359189920197
domInteractive1789372110

@danjm danjm merged commit 29094e0 into Version-v12.3.0 Sep 18, 2024
72 checks passed
@danjm danjm deleted the pnf/cherry-pick-gas-fixes branch September 18, 2024 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Sep 26, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.3.0 on PR, as PR was added to branch 12.3.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants