-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aggregated balance UI #27161
Merged
sahar-fehri
merged 70 commits into
feat/aggregated-balance-feature
from
feat/aggregated-balance-ui
Sep 20, 2024
Merged
feat: aggregated balance UI #27161
Changes from 26 commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
66015b8
feat: add new setting and remove useNativeCurrencyAsPrimaryCurrency s…
sahar-fehri 11fef57
fix: unit test
sahar-fehri b802958
fix: unit test
sahar-fehri 3b76f1a
fix: unit test
sahar-fehri 1798a91
fix: unit test
sahar-fehri 569b657
fix: fix build
sahar-fehri 33dcbcd
fix: fix lint
sahar-fehri f8119eb
fix: fix lint
sahar-fehri dbdff44
fix: rm unused locales and rm primary currency toggle from setting ui
sahar-fehri d470ebb
fix: fix e2e
sahar-fehri 36a48f0
fix: fix e2e sentry
sahar-fehri 529fc19
fix: fix e2e
sahar-fehri 3443032
fix: fix e2e
sahar-fehri 3ea9b32
fix: fix e2e
sahar-fehri f70cd64
fix: fix e2e
sahar-fehri 653bee3
Empty
sahar-fehri 0e4df7d
fix: fix e2e
sahar-fehri 7bb3ff4
fix: remove instances of setting useNativeCurrencyAsPrimaryCurrency
sahar-fehri c0a7d31
fix: fix
sahar-fehri a7b3ff6
fix: added aggregated balance component
sahar-fehri d00f2d3
fix: aggregated balance ui initial commit
sahar-fehri d73a11a
fix: settings ui fixes
sahar-fehri 0c05a3b
fix: fix merge conflicts
sahar-fehri 6194ba1
fix: lint
sahar-fehri 4b9e548
fix: fix after merge conflicts
sahar-fehri 9616888
fix: fix after merge conflicts
sahar-fehri cfa53b6
fix: fix after merge conflicts
sahar-fehri f1308ee
fix: fix test
sahar-fehri a065d71
fix: fix test snapshot
sahar-fehri eaade50
fix: fix duplicate button
sahar-fehri 7238b4f
fix: fix
sahar-fehri 2abb05e
fix: fix snapshot
sahar-fehri d1b61b6
fix: fix snapshot
sahar-fehri 4573acd
fix: fix classnames
sahar-fehri c70a448
fix: fix e2e
sahar-fehri 4835961
fix: fix e2e
sahar-fehri bb44f6f
fix: fix e2e
sahar-fehri 5a74891
fix: fix settings
sahar-fehri 72603c3
fix: fix close icon color
sahar-fehri 5b9835f
fix: rm popover when user clicks on settings
sahar-fehri b65bc1d
fix: rm primary currency from settings search and make show native to…
sahar-fehri 00aab64
fix: fix test
sahar-fehri 05e181b
fix: css ui feedback
sahar-fehri 232a9c2
fix: css ui feedback
sahar-fehri 74b63f5
fix: rm unused locales
sahar-fehri 7762fc8
fix: fix snapshot
sahar-fehri 705dbdf
fix: fix snapshots
sahar-fehri 171f232
fix: fix snapshots
sahar-fehri 6319e80
fix: fix snapshots
sahar-fehri 99866a0
fix: fix add testID
sahar-fehri b4b7442
fix: fix e2e
sahar-fehri 31895a5
fix: e2e
sahar-fehri c400343
fix: CSS feedback
sahar-fehri ed74395
fix: CSS feedback + snapshot update
sahar-fehri 0528eb9
fix: lint
sahar-fehri 78bda56
fix: css fix
sahar-fehri 269d847
fix: update portfolio text css
sahar-fehri 437835f
fix: update snapshot
sahar-fehri 61825b1
fix: portfolio text update
sahar-fehri a6f5fbf
fix: update snapshot
sahar-fehri 523dca3
fix: fix
sahar-fehri 1af5c5a
fix: fix
sahar-fehri ba47af8
fix: lint
sahar-fehri 7bb8de9
fix: fix merge conflicts
sahar-fehri 34b2a84
fix: rm portfolio button class
sahar-fehri 52a8669
fix: fix portfolio buttonLink
sahar-fehri fa835b1
fix: add coin buttons storybook
sahar-fehri 9fe85dd
fix: revert XS buttonIcon change
sahar-fehri 5e720c6
fix: fix popover text css
sahar-fehri a771b75
fix: rm font-size from setting css
sahar-fehri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool one day if we could scope all of these "onboarding" related state variables within a single object, like
onboardingState: {}
to make it easier to understand which vars are related to onboarding vs what's related to the root level metamask state (unrelated to onboarding)