Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove repeated account option #27116

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Sep 12, 2024

Description

This PR fixes an issue about the account option Add a new Bitcoin account (testnet) being repeated.

Open in GitHub Codespaces

Related issues

Fixes: None

Manual testing steps

  1. Enable bitcoin testnet account in the experimental setting
  2. Go to the "Add account" menu

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr requested a review from a team as a code owner September 12, 2024 21:54
@gantunesr gantunesr requested a review from ccharly September 16, 2024 05:16
Copy link
Contributor

@k-g-j k-g-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I only see one add testnet account option now 👍

Screenshot 2024-09-16 at 11 26 50 AM

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gantunesr gantunesr merged commit dac872f into Version-v12.3.0 Sep 16, 2024
69 of 70 checks passed
@gantunesr gantunesr deleted the fix/v12.3.0/repeated-account-option branch September 16, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Sep 26, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.3.0 on PR, as PR was added to branch 12.3.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants