feat: new components for network UI #27085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gambinish
reviewed
Sep 12, 2024
Comment on lines
+77
to
+131
| const renderDropdownList = () => ( | ||
| <Box> | ||
| {items?.map((item, index) => { | ||
| const row = ( | ||
| <Box | ||
| alignItems={AlignItems.center} | ||
| paddingLeft={4} | ||
| paddingRight={4} | ||
| display={Display.Flex} | ||
| justifyContent={JustifyContent.spaceBetween} | ||
| key={itemKey(item)} | ||
| onClick={() => { | ||
| onItemSelected(index); | ||
| setIsDropdownOpen(false); | ||
| }} | ||
| className={classnames('dropdown-editor__item', { | ||
| 'dropdown-editor__item--selected': index === selectedItemIndex, | ||
| })} | ||
| > | ||
| {index === selectedItemIndex && ( | ||
| <Box | ||
| className="dropdown-editor__item-selected-pill" | ||
| borderRadius={BorderRadius.pill} | ||
| backgroundColor={BackgroundColor.primaryDefault} | ||
| /> | ||
| )} | ||
| {renderItem(item, true)} | ||
| {itemIsDeletable(item, items) && ( | ||
| <ButtonIcon | ||
| marginLeft={1} | ||
| ariaLabel={t('delete')} | ||
| size={ButtonIconSize.Sm} | ||
| iconName={IconName.Trash} | ||
| color={IconColor.errorDefault} | ||
| onClick={(e: React.MouseEvent) => { | ||
| e.stopPropagation(); | ||
|
|
||
| // Determine which item should be selected after deletion | ||
| let newSelectedIndex; | ||
| if (selectedItemIndex === undefined || items.length <= 1) { | ||
| newSelectedIndex = undefined; | ||
| } else if (index === selectedItemIndex) { | ||
| newSelectedIndex = 0; | ||
| } else if (index > selectedItemIndex) { | ||
| newSelectedIndex = selectedItemIndex; | ||
| } else if (index < selectedItemIndex) { | ||
| newSelectedIndex = selectedItemIndex - 1; | ||
| } | ||
|
|
||
| onItemDeleted(index, newSelectedIndex); | ||
| }} | ||
| /> | ||
| )} | ||
| </Box> | ||
| ); |
There was a problem hiding this comment.
Not a dealbreaker, but for testing/reusability purposes I would typically prefer to have this live as it's own component, rather than in a callback within dropdown-editor.tsx. Maybe something like multichain-dropdown-list.tsx, and then pass it whatever props it needs.
Doesn't need to block though.
There was a problem hiding this comment.
I agree! Let's consider this as a follow up!
Builds ready [435b3d0]
Page Load Metrics (1726 ± 129 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [26a58c4]
Page Load Metrics (1761 ± 137 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
approved these changes
Sep 12, 2024
gambinish
approved these changes
Sep 12, 2024
salimtb
approved these changes
Sep 12, 2024
Builds ready [6dcaa56]
Page Load Metrics (1806 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Builds ready [7a74433]
Page Load Metrics (1802 ± 140 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #27085 +/- ##
===========================================
- Coverage 70.12% 70.03% -0.09%
===========================================
Files 1426 1432 +6
Lines 49705 49868 +163
Branches 13905 13966 +61
===========================================
+ Hits 34853 34921 +68
- Misses 14852 14947 +95 ☔ View full report in Codecov by Sentry. |
metamaskbot
added
the
release-12.6.0
metamaskbot
added
the
release-12.5.0
metamaskbot
removed
the
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits off the new UI components from #26433. They support the new UI for editing networks directly via the network picker.
MultiRpcEditModal- A modal shown only to users who have multiple networks for a given chain. Allows them to customize via the network form if they don't like how we merged them.DropdownEditor- A generic dropdown for selecting, adding, and deleting items. Currently shared by the editing experience for RPC endpoints and block explorers.AddBlockExplorerModal- The sub page within the network form where you add a block explorerAddRpcUrlModal- The sub page within the network form where you add an RPC urlRpcListItem- A component representing a single RPC endpoint with a list. Currently shared between selecting via theSelectRpcUrlModaland editing via the RPCDropdownEditorSelectRpcUrlModal- The page used to switch RPC endpoints for a chain.Additionally some actions are modified to support new features used by these components.
Related issues
Manual testing steps
None of these are visible in the product yet, but will be after #26433
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist