Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(26919): bump @metamask/signature-controller to 19.0.0 and @metamask/logging-controller to 6.0.0 #27082

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Sep 11, 2024

Description

In order to achieve core release v194, this PR bumps @metamask/signature-controller to 19.0.0 and @metamask/logging-controller to 6.0.0.
ChangeLog for each controllers are:

Open in GitHub Codespaces

Related issues

Fixes: #26919

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica self-assigned this Sep 11, 2024
@DDDDDanica DDDDDanica requested a review from a team as a code owner September 11, 2024 22:41
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Sep 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 96.1 kB metamaskbot
npm/@metamask/[email protected] None 0 0 B

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

@DDDDDanica
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot metamaskbot requested a review from a team as a code owner September 12, 2024 01:24
@metamaskbot
Copy link
Collaborator

Builds ready [d0a6169]
Page Load Metrics (1631 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28320931509448215
domContentLoaded13732037161418589
load13762091163119192
domInteractive127737168
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -25.1 KiB (-0.70%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot
Copy link
Collaborator

Builds ready [6a0d44b]
Page Load Metrics (1641 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint20023191581373179
domContentLoaded14632311162318689
load14712320164119091
domInteractive138732178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -25.1 KiB (-0.70%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (5053c3e) to head (3443cc7).
Report is 86 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #27082   +/-   ##
========================================
  Coverage    70.12%   70.12%           
========================================
  Files         1426     1426           
  Lines        49705    49705           
  Branches     13905    13905           
========================================
  Hits         34853    34853           
  Misses       14852    14852           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [3443cc7]
Page Load Metrics (2397 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13527131848918441
domContentLoaded189429292369255122
load193929412397253121
domInteractive14100452110
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -25.11 KiB (-0.70%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@vthomas13 vthomas13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for going over this with me @DDDDDanica

Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DDDDDanica DDDDDanica merged commit 8dc56d4 into develop Sep 13, 2024
78 checks passed
@DDDDDanica DDDDDanica deleted the chore/26919 branch September 13, 2024 14:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 13, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

LoggingController and SignatureController upgrade
4 participants