-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(26919): bump @metamask/signature-controller
to 19.0.0 and @metamask/logging-controller
to 6.0.0
#27082
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected] |
@metamaskbot update-policies |
Policies updated |
Builds ready [d0a6169]
Page Load Metrics (1631 ± 92 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
d0a6169
to
fcfd7e6
Compare
@metamaskbot update-policies |
Policies updated |
Builds ready [6a0d44b]
Page Load Metrics (1641 ± 91 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
…etamask/logging-controller` to 6.0.0
6a0d44b
to
bc1d800
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27082 +/- ##
========================================
Coverage 70.12% 70.12%
========================================
Files 1426 1426
Lines 49705 49705
Branches 13905 13905
========================================
Hits 34853 34853
Misses 14852 14852 ☔ View full report in Codecov by Sentry. |
Builds ready [3443cc7]
Page Load Metrics (2397 ± 121 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for going over this with me @DDDDDanica
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
Description
In order to achieve core release v194, this PR bumps
@metamask/signature-controller
to 19.0.0 and@metamask/logging-controller
to 6.0.0.ChangeLog for each controllers are:
Related issues
Fixes: #26919
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist