Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): cannot use double-quotes in filenames on Windows #27071

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Sep 11, 2024

Description

#26764 created files with double-quotes in filenames. Windows cannot handle that, and gives this error

Check Out Branch:
invalid path 'test/manual-scenarios/privacy-settings/check "Display NFT media" toggle works correctly.md'
invalid path 'test/manual-scenarios/privacy-settings/check "IPFS gateway" toggle works correctly.md'
invalid path 'test/manual-scenarios/privacy-settings/check "Network details check" toggle works correctly.md'
invalid path 'test/manual-scenarios/privacy-settings/check "Show ENS domains in address bar" toggle works correctly.md'

Renamed to use single quotes.

Open in GitHub Codespaces

Related issues

Fixes: #26764

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@hjetpoluru hjetpoluru self-requested a review September 11, 2024 16:50
@hjetpoluru hjetpoluru merged commit 4c73dc6 into develop Sep 11, 2024
84 of 85 checks passed
@hjetpoluru hjetpoluru deleted the no-double-quotes branch September 11, 2024 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1b19762]
Page Load Metrics (1778 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22325091612505243
domContentLoaded153824871758216104
load154624971778217104
domInteractive147334157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@HowardBraham HowardBraham added team-tiger Tiger team (for tech debt reduction + performance improvements) contributor experience An issue that impacts, or planned improvement to, the contributor experience. and removed team-contributor-experience labels Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor experience An issue that impacts, or planned improvement to, the contributor experience. release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants