Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move scroll to bottom related state on re-designed confirmation pages to confirmContext #27064

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 11, 2024

Description

Move scroll to bottom related state on re-designed confirmation pages to confirmContext

Related issues

Fixes: #26970

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Sep 11, 2024
@jpuri jpuri requested review from a team as code owners September 11, 2024 14:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.10%. Comparing base (3797b2f) to head (676a4db).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #27064      +/-   ##
===========================================
- Coverage    70.15%   70.10%   -0.05%     
===========================================
  Files         1425     1425              
  Lines        49656    49671      +15     
  Branches     13892    13898       +6     
===========================================
- Hits         34833    34819      -14     
- Misses       14823    14852      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [676a4db]
Page Load Metrics (1697 ± 115 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint20121061398595285
domContentLoaded139223521678238114
load142824001697240115
domInteractive216533147

@jpuri jpuri merged commit 8816378 into develop Sep 12, 2024
78 checks passed
@jpuri jpuri deleted the scroll_to_bottom_refactor branch September 12, 2024 11:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 12, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: Move Confirmation scroll-to-bottom into a React Context
4 participants